From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8] Introduced btrfs file-system with btrload command
Date: Tue, 19 Mar 2013 10:35:04 -0400 [thread overview]
Message-ID: <20130319143504.GE25919@bill-the-cat> (raw)
In-Reply-To: <1363613000-29473-2-git-send-email-adnan.ali@codethink.co.uk>
On Mon, Mar 18, 2013 at 01:23:20PM +0000, Adnan Ali wrote:
> Introduces btrfs file-system to read file from
> volume/sub-volumes with btrload command. This
> implementation has read-only support.
> This btrfs implementation is based on syslinux btrfs
> code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
>
> v8: patch re-formated.
> v7: patch re-formated.
> v6: patch re-formated.
> v5: merged with master.
> v4: btrls command added.
>
> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk>
I'm sorry, but there's still some pretty severe checkpatch warnings
introduced here over syslinux such as:
ERROR: do not use assignment in if condition
#525: FILE: btrfs/btrfs.c:525:
+ if (status = btrfs_comp_keys_type(&search_key,
Please use "./tools/checkpatch.pl -f fs/btrfs/btrfs.c" and -f
/path/to/syslinux/core/fs/btrfs/btrfs.c and fix the things that are
being introduced and quite possibly bugs like the above.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130319/cd1e67f8/attachment.pgp>
next prev parent reply other threads:[~2013-03-19 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 13:23 [U-Boot] [PATCH v8] Addition of btrfs file-system to U-boot Adnan Ali
2013-03-18 13:23 ` [U-Boot] [PATCH v8] Introduced btrfs file-system with btrload command Adnan Ali
2013-03-19 14:35 ` Tom Rini [this message]
2013-03-19 15:25 ` Adnan Ali
2013-03-19 15:28 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319143504.GE25919@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.