Re: [LTP] [PATCH] inode02: fix "slash" array overrun

[chrubis@suse.cz]

Hi!
> testcases/kernel/fs/inode/inode02.c:254 is initializing it as:
>     slash[0] = '/';
>     slash[1] = '\0';
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>  testcases/kernel/fs/inode/inode02.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/kernel/fs/inode/inode02.c b/testcases/kernel/fs/inode/inode02.c
> index 783edf8..f70c5d8 100644
> --- a/testcases/kernel/fs/inode/inode02.c
> +++ b/testcases/kernel/fs/inode/inode02.c
> @@ -80,7 +80,7 @@ int nchild;
>  FILE *list_stream = NULL;
>  int list_id;
>  int file_id;
> -char slash[1];
> +char slash[2];

Good catch, but could you go ahead and convert the strcats into one
snprintf() so that the slash array wouldn't be needed at all?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list