From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 10/10] [v2] drm/i915: Add a pipeless ivybridge configuration Date: Tue, 19 Mar 2013 11:49:49 -0700 Message-ID: <20130319184948.GC1450@bwidawsk.net> References: <1363371475-855-1-git-send-email-ben@bwidawsk.net> <1363371475-855-10-git-send-email-ben@bwidawsk.net> <20130317214233.GE9021@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 533E6E65E1 for ; Tue, 19 Mar 2013 11:47:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130317214233.GE9021@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Mar 17, 2013 at 10:42:33PM +0100, Daniel Vetter wrote: > On Fri, Mar 15, 2013 at 11:17:55AM -0700, Ben Widawsky wrote: > > FIXME: This is based on some HW being used for a demo. We should > > probably wait until we have confirmation on the IDs before upstreaming > > this patch. > > I don't mind too much if we need to fixup the device after the fact, but > checking whether this is the shipping configuration shouldn't hurt. > > More important is probably whether there's any quanta platform with the > same sdev/svendor ids without a fused pch. In that case I guess we need to > check for something else (maybe some fuse flags in the pch?). I highly doubt it, but I don't know how to prove it. From what I gather on the internet and parsing through the limited uses in the kernel today, the subvendor/subdevice is unique. > > Anyway, I've done a pretty careful review of everything, mostly looking to > reduce the impact of this feature on our code. So if you respin and > quickly test this on an real ivb (just for paranoia) and the special box > I'll merge it right away. Imo the maintenance burned is really small, so > I'm not against merging this in the demo stage. I've rebased on nightly and tried to apply all the requests (assuming I didn't miss any). Because I am at home today, and testing displayless at home is sort of a pain, this is untested on both regular IVB (the rebase did have a conflict), and the Quanta server. I can test it on regular IVB tomorrow, and I'll begin trying to get it tested on the Quanta thing ASAP, but it could be a few days. Meanwhile, I've pushed the respun patches here: http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=pch_displayless > > Cheers, Daniel Thanks for the review. [snip] > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Ben Widawsky, Intel Open Source Technology Center