From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf-next] netfilter: nfnetlink_queue: zero copy support
Date: Tue, 19 Mar 2013 23:52:43 +0100 [thread overview]
Message-ID: <20130319225243.GA3657@localhost> (raw)
In-Reply-To: <1363576555.29475.122.camel@edumazet-glaptop>
On Sun, Mar 17, 2013 at 08:15:55PM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> nfqnl_build_packet_message() actually copy the packet
> inside the netlink message, while it can instead use
> zero copy.
>
> Make sure the skb 'copy' is the last component of the
> cooked netlink message, as we cant add anything after it.
>
> Patch cooked in Copenhagen at Netfilter Workshop ;)
>
> Still to be addressed in separate patches :
>
> -GRO/GSO packets are segmented in nf_queue()
> and checksummed in nfqnl_build_packet_message().
>
> Proper support for GSO/GRO packets (no segmentation,
> and no checksumming) needs application cooperation, if we
> want no regressions.
Applied, thanks.
prev parent reply other threads:[~2013-03-19 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 3:15 [PATCH nf-next] netfilter: nfnetlink_queue: zero copy support Eric Dumazet
2013-03-18 9:24 ` Florian Westphal
2013-03-18 13:51 ` Eric Dumazet
2013-03-18 15:36 ` Pablo Neira Ayuso
2013-03-19 22:52 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319225243.GA3657@localhost \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.