From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-next@vger.kernel.org
Subject: Re: add_taint() change left s390 alone
Date: Wed, 20 Mar 2013 10:19:15 +0100 [thread overview]
Message-ID: <20130320091915.GB13679@osiris> (raw)
In-Reply-To: <20130320200819.7ebe1f2c5a9fe73e3f024e2b@canb.auug.org.au>
On Wed, Mar 20, 2013 at 08:08:19PM +1100, Stephen Rothwell wrote:
> Hi Heilo,
>
> On Wed, 20 Mar 2013 09:38:44 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> >
> > your commit "taint: add explicit flag to show whether lock dep is still OK."
> > missed to change the s390 invocation of add_taint():
> >
> > CC arch/s390/kernel/dumpstack.o
> > arch/s390/kernel/dumpstack.c: In function ‘die’:
> > arch/s390/kernel/dumpstack.c:228:2: error: too few arguments to function ‘add_taint’
> >
> > Could be that this is a merge issue since dumpstack.c is a new file which
> > contains stuff that was formerly in arch/s390/kernel/traps.c
>
> The commit (9ff3d92a818e "s390/dumpstack: fix call chain walking" in
> today's version of the s390 tree) that adds dumpstack.c has add_taint()
> with 2 arguments removed from traps.c and add_taint() with one argument
> added to dumpstack.c ... and add_taint() already has 2 arguments in that
> tree ...
Ouch! Looks like our work flow still sucks.
Sorry for the noise and blaming others, we'll fix it up!
prev parent reply other threads:[~2013-03-20 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 8:38 add_taint() change left s390 alone Heiko Carstens
2013-03-20 9:08 ` Stephen Rothwell
2013-03-20 9:19 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320091915.GB13679@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=linux-next@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.