From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Cc: tiwai@suse.de, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] sound: soc: fix invalid free of devm_ allocated data
Date: Wed, 20 Mar 2013 11:05:30 +0100 [thread overview]
Message-ID: <20130320100529.GH28775@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1363434334-5461-1-git-send-email-silviupopescu1990@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]
On Sat, Mar 16, 2013 at 01:45:34PM +0200, Silviu-Mihai Popescu wrote:
> The objects allocated by devm_* APIs are managed by devres and are freed when
> the device is detached. Hence there is no need to use kfree() explicitly.
In this case since we're in error handling paths which might not be
fatal (though I suspect they probably should be normally) it looks like
the better fix is to use devm_kfree() to free immediately. Otherwise
the unused memory will end up hanging around for as long as the device
is bound.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-03-20 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 11:45 [PATCH] sound: soc: fix invalid free of devm_ allocated data Silviu-Mihai Popescu
2013-03-20 10:05 ` Mark Brown [this message]
2013-03-20 10:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320100529.GH28775@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=silviupopescu1990@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.