From: Al Viro <viro@ZenIV.linux.org.uk>
To: Shankar Brahadeeswaran <shankoo77@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Hugh Dickins <hughd@google.com>
Subject: Re: [BUG] staging: android: ashmem: Deadlock during ashmem_mmap and ashmem_read
Date: Wed, 20 Mar 2013 16:08:53 +0000 [thread overview]
Message-ID: <20130320160853.GP21522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAJsYZ5ksvPCR2O39=sj9zeptfppP1w6FM08rw8Aw+L+2dEPCnQ@mail.gmail.com>
On Wed, Mar 20, 2013 at 09:08:03PM +0530, Shankar Brahadeeswaran wrote:
> Hi Greg, Dan,
>
> Few days back I posted a patch to fix a dead lock issue in the ashmem
> driver that got merged in staging-next branch
> https://lkml.org/lkml/2013/2/20/429
>
> I'm seeing that there exists another path in the ashmem driver that
> could lead to the similar issue. But this time I'm unable to think of
> a way to fix the problem.
>
> - The objects involved in the deadlock are same, mmap->sem and ashmem_mutex
Umm... why does it need to hold that mutex past having checked that
asma->file is non-NULL, anyway?
next prev parent reply other threads:[~2013-03-20 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 15:38 [BUG] staging: android: ashmem: Deadlock during ashmem_mmap and ashmem_read Shankar Brahadeeswaran
2013-03-20 16:08 ` Al Viro [this message]
2013-03-20 16:53 ` Greg Kroah-Hartman
2013-03-21 4:03 ` Shankar Brahadeeswaran
[not found] ` <CAJtyJaVnUZXkWdma8YydpU6tEF2KEhrWz+uq6D142gDwX3fATg@mail.gmail.com>
2013-03-21 14:18 ` Robert Love
[not found] ` <CAJtyJaWRzng7XuGixXKLLATERNSV3FYkTN7kH55RJcmHs1BjCQ@mail.gmail.com>
2013-03-22 14:42 ` Shankar Brahadeeswaran
2013-03-22 16:47 ` Shankar Brahadeeswaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320160853.GP21522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shankoo77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.