All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 1/6] remote.c: simplify a bit of code using git_config_string()
Date: Wed, 20 Mar 2013 11:07:07 -0700	[thread overview]
Message-ID: <20130320180707.GH3655@google.com> (raw)
In-Reply-To: <1363783501-27981-2-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

> --- a/remote.c
> +++ b/remote.c
> @@ -356,9 +356,7 @@ static int handle_config(const char *key, const char *value, void *cb)
>  			return 0;
>  		branch = make_branch(name, subkey - name);
>  		if (!strcmp(subkey, ".remote")) {
> -			if (!value)
> -				return config_error_nonbool(key);
> -			branch->remote_name = xstrdup(value);
> +			git_config_string(&branch->remote_name, key, value);

Shouldn't this say

			if (git_config_string(&branch->remote_name, key, value))
				return -1;

or something?

Thanks,
Jonathan

  reply	other threads:[~2013-03-20 18:07 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 12:44 [PATCH v2 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-20 12:44 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra
2013-03-20 18:07   ` Jonathan Nieder [this message]
2013-03-20 18:12     ` Ramkumar Ramachandra
2013-03-20 12:44 ` [PATCH 2/6] t5516 (fetch-push): update test description Ramkumar Ramachandra
2013-03-20 18:22   ` Jonathan Nieder
2013-03-20 18:33     ` Ramkumar Ramachandra
2013-03-20 18:35       ` Jonathan Nieder
2013-03-20 12:44 ` [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name() Ramkumar Ramachandra
2013-03-20 18:28   ` Jonathan Nieder
2013-03-20 18:38     ` Ramkumar Ramachandra
2013-03-20 18:41       ` Jonathan Nieder
2013-03-20 18:58         ` Jeff King
2013-03-20 19:52           ` Junio C Hamano
2013-03-20 20:00           ` Jonathan Nieder
2013-03-20 12:44 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
2013-03-20 18:30   ` Jonathan Nieder
2013-03-20 19:03   ` Junio C Hamano
2013-03-20 19:43     ` Ramkumar Ramachandra
2013-03-20 19:48       ` Junio C Hamano
2013-03-20 12:45 ` [PATCH 5/6] remote.c: introduce remote.pushdefault Ramkumar Ramachandra
2013-03-20 18:32   ` Jonathan Nieder
2013-03-20 18:53     ` Junio C Hamano
2013-03-20 19:46     ` Ramkumar Ramachandra
2013-03-20 12:45 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Ramkumar Ramachandra
2013-03-20 13:03   ` Tay Ray Chuan
2013-03-20 13:35     ` Ramkumar Ramachandra
2013-03-20 13:06 ` [PATCH v2 0/6] Support triangular workflows Tay Ray Chuan
2013-03-22  7:44   ` Ramkumar Ramachandra
2013-03-20 23:04 ` Philip Oakley
2013-03-22  7:41   ` Ramkumar Ramachandra
2013-03-22 15:16   ` Junio C Hamano
2013-03-23 12:42     ` Ramkumar Ramachandra
  -- strict thread matches above, loose matches on Subject: below --
2013-03-22  7:52 [PATCH v3 " Ramkumar Ramachandra
2013-03-22  7:52 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra
2013-03-22 18:26   ` Jonathan Nieder
2013-03-28 13:26 [PATCH v4 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-28 13:26 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra
2013-04-02  7:40 [PATCH 0/6] Re-roll rr/triangle Ramkumar Ramachandra
2013-04-02  7:40 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130320180707.GH3655@google.com \
    --to=jrnieder@gmail.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.