All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] Added package HPLIP for printing to HP printers
Date: Wed, 20 Mar 2013 19:11:31 +0100	[thread overview]
Message-ID: <20130320191131.2fb8a9f5@skate> (raw)
In-Reply-To: <20130319121031.EF25A9B19C@busybox.osuosl.org>

Dear Peter Korsgaard,

On Tue, 19 Mar 2013 13:07:39 +0100, Peter Korsgaard wrote:

> diff --git a/package/Config.in b/package/Config.in
> index fec5020..e12228f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -640,6 +640,7 @@ source "package/connman/Config.in"
>  source "package/ctorrent/Config.in"
>  source "package/conntrack-tools/Config.in"
>  source "package/cups/Config.in"
> +source "package/hplip/Config.in"

This breaks the rule of sorting alphabetically the packages. I know it
has been made to avoid the submenu related to Printing stuff... but
since Olivier is contributing more printing-related packages, maybe the
submenu was a better option?

> diff --git a/package/hplip/Config.in b/package/hplip/Config.in
> new file mode 100644
> index 0000000..5bcd63b
> --- /dev/null
> +++ b/package/hplip/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_HPLIP
> +	bool "hplip"
> +	depends on BR2_PACKAGE_CUPS
> +	select BR2_PACKAGE_LIBUSB
> +	select BR2_PACKAGE_JPEG

Missing 'depends on BR2_INSTALL_LIBSTDCPP' ...

> +	help
> +	  HP Linux Imaging and Printing (HPLIP)
> +	  HPLIP is an HP-developed solution for printing, scanning, and faxing
> +	  with HP inkjet and laser based printers in Linux. The HPLIP project
> +	  provides printing support for 2,211 printer models, including
> +	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business
> +	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP.
> +
> +	  http://hplipopensource.com/
> +
> +comment "hplip requires a toolchain with C++ support enabled"
> +	depends on !BR2_INSTALL_LIBSTDCPP

... since we're doing the opposite check here :)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-03-20 18:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 12:07 [Buildroot] [git commit] Added package HPLIP for printing to HP printers Peter Korsgaard
2013-03-20 18:11 ` Thomas Petazzoni [this message]
2013-03-20 19:49   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130320191131.2fb8a9f5@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.