From: Jiri Benc <jbenc@redhat.com>
To: "Vick, Matthew" <matthew.vick@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
Stefan Assmann <sassmann@redhat.com>,
Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: [PATCH] igb: fix PHC stopping on max freq
Date: Wed, 20 Mar 2013 20:11:53 +0100 [thread overview]
Message-ID: <20130320201153.7fc5e844@griffin> (raw)
In-Reply-To: <CD6E221E.1657D%matthew.vick@intel.com>
On Tue, 19 Mar 2013 21:17:25 +0000, Vick, Matthew wrote:
> Good catch on this, Jiri! I know the math works out the same, but I'd
> prefer it if you changed the max_adj value to 999999999, since that is
> technically what we can accept before we have any issues. If you re-submit
> with this change, I'll add my ACK and we can run it through our internal
> testing. Thanks!
But the real maximum value is actually 999999881, as anything higher
than that would be capped to 999999881 by the driver. I don't think the
driver should advertise higher max_adj than it is able to fulfill,
otherwise there would be no need for the field.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2013-03-20 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 14:42 [PATCH] igb: fix PHC stopping on max freq Jiri Benc
2013-03-19 21:17 ` Vick, Matthew
2013-03-20 19:11 ` Jiri Benc [this message]
2013-03-20 22:55 ` Vick, Matthew
2013-03-20 0:49 ` Jeff Kirsher
2013-04-09 13:26 ` [E1000-devel] " Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320201153.7fc5e844@griffin \
--to=jbenc@redhat.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=matthew.vick@intel.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.