From: Marcelo Tosatti <mtosatti@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "kvm@vger.kernel.org list:Overall" <kvm@vger.kernel.org>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: KVM next tree merge onto current Linus master
Date: Thu, 21 Mar 2013 12:47:30 -0300 [thread overview]
Message-ID: <20130321154730.GA4460@amt.cnet> (raw)
In-Reply-To: <93606445-F2D9-42C3-A8A9-202FE3E69B98@suse.de>
On Thu, Mar 21, 2013 at 08:49:07AM +0100, Alexander Graf wrote:
> Hi guys,
>
> Just recently this really important patch got pulled into Linus' tree for 3.9:
>
> commit 1674400aaee5b466c595a8fc310488263ce888c7
> Author: Anton Blanchard <anton@samba.org>
> Date: Tue Mar 12 01:51:51 2013 +0000
>
> powerpc: Fix -mcmodel=medium breakage in prom_init.c
>
> Commit 5ac47f7a6efb (powerpc: Relocate prom_init.c on 64bit) made
> prom_init.c position independent by manually relocating its entries
> in the TOC.
>
> We get the address of the TOC entries with the __prom_init_toc_start
> linker symbol. If __prom_init_toc_start ends up as an entry in the
> TOC then we need to add an offset to get the current address. This is
> the case for older toolchains.
>
> On the other hand, if we have a newer toolchain that supports
> -mcmodel=medium then __prom_init_toc_start will be created by a
> relative offset from r2 (the TOC pointer). Since r2 has already been
> relocated, nothing more needs to be done. Adding an offset in this
> case is wrong and Aaro Koskinen and Alexander Graf have noticed noticed
> G5 and OpenBIOS breakage.
>
> Alan Modra suggested we just use r2 to get at the TOC which is simpler
> and works with both old and new toolchains.
>
> Reported-by: Alexander Graf <agraf@suse.de>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
>
> Without that commit, I can not boot my G5, thus I can't run automated tests on it against my queue.
>
> Could you please merge kvm/next against linus/master, so that I can base my trees against that?
>
>
> Alex
Done, will push master as soon as autotest finishes.
prev parent reply other threads:[~2013-03-21 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 7:49 KVM next tree merge onto current Linus master Alexander Graf
2013-03-21 15:47 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321154730.GA4460@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.