From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55398 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082Ab3CUTFb convert rfc822-to-8bit (ORCPT ); Thu, 21 Mar 2013 15:05:31 -0400 Date: Thu, 21 Mar 2013 16:05:22 -0300 From: Mauro Carvalho Chehab To: Frank =?UTF-8?B?U2Now6RmZXI=?= Cc: Hans Verkuil , Linux Media Mailing List Subject: Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900 Message-ID: <20130321160522.01e183a7@redhat.com> In-Reply-To: <514B4F8E.3030705@googlemail.com> References: <201303210933.41537.hverkuil@xs4all.nl> <20130321070327.772c6301@redhat.com> <201303211634.13057.hverkuil@xs4all.nl> <514B4F8E.3030705@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org List-ID: Em Thu, 21 Mar 2013 19:21:02 +0100 Frank Schäfer escreveu: > Am 21.03.2013 16:34, schrieb Hans Verkuil: > > On Thu March 21 2013 11:03:27 Mauro Carvalho Chehab wrote: > >> Em Thu, 21 Mar 2013 09:33:41 +0100 > >> Hans Verkuil escreveu: > >> > >>> I tried to use my HVR 900 stick today and discovered that it no longer worked. > >>> I traced it to commit aab3125c43d8fecc7134e5f1e729fabf4dd196da: "em28xx: add > >>> support for registering multiple i2c buses". > >>> > >>> The kernel messages for when it fails are: > >> ... > >>> Mar 21 09:26:57 telek kernel: [ 1396.542517] xc2028 12-0061: attaching existing instance > >>> Mar 21 09:26:57 telek kernel: [ 1396.542521] xc2028 12-0061: type set to XCeive xc2028/xc3028 tuner > >>> Mar 21 09:26:57 telek kernel: [ 1396.542523] em2882/3 #0: em2882/3 #0/2: xc3028 attached > >> ... > >>> Mar 21 09:26:57 telek kernel: [ 1396.547833] xc2028 12-0061: Error on line 1293: -19 > >> Probably, the I2C speed is wrong. I noticed a small bug on this patch. > >> The following patch should fix it. Could you please test? > > No luck, it didn't help. > > I can't test it at the moment, but I have the same device and also > tested at least two other (non-em28xx) devices with the xc3028 during > the last weeks. > With all devices, I'm often getting i2c errors like this, too. Usually > only a few not affecting the device operation, but sometimes the log is > full of them and I have to unplugg the device and plug it in again to > make it work. > So something might be wrong with the xc3028 driver... I doubt that this is the cause. It could be some race condition between the main em28xx driver and some other one (we had this issue in the past). Also, there's no situation at xc3028 driver where ENODEV is returned. So, this is likely at em28xx-i2c, where this error is returned when the physical device doesn't answer to an I2C xfer. Regards, Mauro