All of lore.kernel.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/3] clk: Restructure code for __clk_reparent
Date: Thu, 21 Mar 2013 13:53:10 -0700	[thread overview]
Message-ID: <20130321205310.834.2857@quantum> (raw)
In-Reply-To: <1363873693-30902-2-git-send-email-ulf.hansson@stericsson.com>

Quoting Ulf Hansson (2013-03-21 06:48:11)
> +void __clk_reparent(struct clk *clk, struct clk *new_parent)
> +{
> +       clk_reparent(clk, new_parent);
> +       clk_debug_reparent(clk, new_parent);
>         __clk_recalc_rates(clk, POST_RATE_CHANGE);
>  }
>  
> @@ -1364,7 +1378,9 @@ int clk_set_parent(struct clk *clk, struct clk *parent)
>         }
>  
>         /* propagate rate recalculation downstream */
> -       __clk_reparent(clk, parent);
> +       clk_reparent(clk, parent);
> +       clk_debug_reparent(clk, parent);
> +       __clk_recalc_rates(clk, POST_RATE_CHANGE);
>  

This is an interesting change.  Why not call __clk_reparent here instead
of open coding an identical sequence?

Regards,
Mike

  reply	other threads:[~2013-03-21 20:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 13:48 [PATCH V2 0/3] clk: Fixup issues for clk_set_parent Ulf Hansson
2013-03-21 13:48 ` [PATCH V2 1/3] clk: Restructure code for __clk_reparent Ulf Hansson
2013-03-21 20:53   ` Mike Turquette [this message]
2013-03-22 11:08     ` Ulf Hansson
2013-03-22 20:39       ` Mike Turquette
2013-03-21 13:48 ` [PATCH V2 2/3] clk: Improve errorhandling for clk_set_parent Ulf Hansson
2013-03-21 21:00   ` Mike Turquette
2013-03-22  9:59     ` Rajagopal Venkat
2013-03-22 20:41       ` Mike Turquette
2013-03-22 11:13     ` Ulf Hansson
2013-03-21 13:48 ` [PATCH V2 3/3] clk: Fixup locking issues " Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130321205310.834.2857@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.