From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Ley Foon Tan <lftan@altera.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, Rob Landley <rob@landley.net>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: of_serial: Handle fifosize property
Date: Fri, 22 Mar 2013 09:41:54 +0200 [thread overview]
Message-ID: <20130322074154.GA9250@xps8300> (raw)
In-Reply-To: <1363923138.2289.14.camel@leyfoon-vm>
On Fri, Mar 22, 2013 at 11:32:18AM +0800, Ley Foon Tan wrote:
> On Thu, 2013-03-21 at 15:24 +0200, Heikki Krogerus wrote:
> > On Thu, Mar 21, 2013 at 07:41:39PM +0800, Ley Foon Tan wrote:
> > > Suggest to use "fifo-size" for the device tree property, to align with
> > > other DT properties.
> >
> > I was going to, but then I noticed that in some .dtsi files "fifosize"
> > is used with uarts. Should I still change it?
> I just make the grep for "fifosize" in arch/. It is used by other serial
> drivers (not of_serial.c). So, you are safe to change it to "fifo-size".
OK, I'll change it.
Thanks!
--
heikki
next prev parent reply other threads:[~2013-03-22 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 2:28 [PATCH] tty/serial: Add support for Altera serial port Ley Foon Tan
2013-03-07 2:28 ` Ley Foon Tan
2013-03-21 10:46 ` Heikki Krogerus
2013-03-21 10:47 ` [PATCH 1/2] serial: 8250: Allow probe drivers to ignore tx_loadsz Heikki Krogerus
2013-03-21 10:48 ` [PATCH 2/2] serial: of_serial: Handle fifosize property Heikki Krogerus
2013-03-21 11:41 ` Ley Foon Tan
2013-03-21 11:41 ` Ley Foon Tan
2013-03-21 13:24 ` Heikki Krogerus
2013-03-22 3:32 ` Ley Foon Tan
2013-03-22 3:32 ` Ley Foon Tan
2013-03-22 7:41 ` Heikki Krogerus [this message]
2013-03-22 8:05 ` [PATCHv2 2/2] serial: of_serial: Handle fifo-size property Heikki Krogerus
2013-03-22 8:16 ` Ley Foon Tan
2013-03-22 8:16 ` Ley Foon Tan
2013-03-22 9:24 ` Heikki Krogerus
2013-03-25 8:42 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322074154.GA9250@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.