Re: [PATCH 2/2 resend] ASoC: cs4271: preserve "Master Playback Switch" setting

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 891 bytes --]

On Thu, Mar 21, 2013 at 08:43:55PM +0100, Daniel Mack wrote:
> Currently, both the ALSA control for "Digital Master Playback Switch"
> and the ALSA core (by calling dai_ops->mute_stream()) control the same
> bits in the CS4271_VOL[AB]_MUTE registers.

> That's a problem for applications which intentionally want to keep the
> flag switched off from userspace, even though the stream is already
> playing.

> Fix this by keeping track of the states on both sides - the ALSA
> control and the ASoC core - and actually mute the Codec if either one
> of the two flags is set.

The usual fix for this is to just not have the mute operation if it's
important.  Otherwise this seems like something we ought to implement in
the core, it's not a silly feature by any stretch of the imagination but
it applies to any device with a DAI mute unless there's some device
specific thing I'm missing here.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]