From: Eric Wong <normalperson@yhbt.net>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: linux-kernel@vger.kernel.org,
Davide Libenzi <davidel@xmailserver.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC v3 1/2] epoll: avoid spinlock contention with wfcqueue
Date: Fri, 22 Mar 2013 10:31:02 +0000 [thread overview]
Message-ID: <20130322103102.GA4818@dcvr.yhbt.net> (raw)
In-Reply-To: <CAMP5XgcPG6-ikNE5jQHL9vNVPrM4wrMb8HYfYcEfT2hW6a2pUA@mail.gmail.com>
Arve Hjønnevåg <arve@android.com> wrote:
> On Thu, Mar 21, 2013 at 8:24 PM, Eric Wong <normalperson@yhbt.net> wrote:
> >
> > With EPOLLET and improper usage (not hitting EAGAIN), the event now
> > has a larger window to be lost (as mentioned in my changelog).
> >
>
> What about the case where EPOLLET is not set? The old code did not
> drop events in that case.
Nothing is dropped, if the event wasn't on the ready list before,
ep_poll_callback may still append the ready list while __put_user
is running.
If the event was on the ready list:
1) It does not matter for EPOLLONESHOT, it'll get masked out and
discarded in the next ep_send_events call until ep_modify reenables
it. Since ep_modify and ep_send_events both take ep->mtx, there's
no conflict.
2) Level Trigger - event stays ready, so nothing is dropped.
> > As far as correct __pm_stay_awake/__pm_relax handling, perhaps adding
> > an atomic counter to struct eventpoll (or each epitem) will work?
>
> The wakeup_source should stay in sync with the epoll state. I don't
> think any additional state is needed.
The problem is epi->state is not set atomically in ep_send_events,
Having atomic operations in the loop hurts performance (early versions
of this patch did that, and hurt the single-threaded case).
Maybe I'll only set epi->state atomically if epi->ws is used...
> > If we go with atomic counter in struct eventpoll, is per-epitem
> > wakeup_source still necessary? We have space in epitem now, but
> > maybe one day we will might need it.
> >
>
> The wakeup_source per epitem is useful for accounting reasons. If
> suspend fails, it is useful to know which device caused it.
OK. I'll keep epitem->ws
next prev parent reply other threads:[~2013-03-22 10:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 11:52 [RFC v3 1/2] epoll: avoid spinlock contention with wfcqueue Eric Wong
2013-03-21 11:54 ` [RFC v3 2/2] epoll: use a local wfcq functions for Level Trigger Eric Wong
2013-03-21 12:01 ` [RFC v3 1/2] epoll: avoid spinlock contention with wfcqueue Eric Wong
2013-03-22 1:39 ` Arve Hjønnevåg
2013-03-22 3:24 ` Eric Wong
2013-03-22 3:24 ` Eric Wong
2013-03-22 4:07 ` Arve Hjønnevåg
2013-03-22 4:07 ` Arve Hjønnevåg
2013-03-22 10:31 ` Eric Wong [this message]
2013-03-22 19:24 ` Eric Wong
2013-03-22 22:27 ` Arve Hjønnevåg
2013-03-22 22:18 ` Arve Hjønnevåg
2013-03-22 22:18 ` Arve Hjønnevåg
2013-03-22 22:54 ` Eric Wong
2013-03-23 10:16 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322103102.GA4818@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=davidel@xmailserver.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.