All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org, subaparts@yandex.ru, lgirdwood@gmail.com
Subject: Re: [PATCH 2/2 resend] ASoC: cs4271: preserve "Master Playback Switch" setting
Date: Fri, 22 Mar 2013 11:32:47 +0100	[thread overview]
Message-ID: <20130322103247.GF22890@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <514C3124.8010806@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 764 bytes --]

On Fri, Mar 22, 2013 at 11:23:32AM +0100, Daniel Mack wrote:
> On 22.03.2013 11:18, Mark Brown wrote:

> > The usual fix for this is to just not have the mute operation if it's
> > important.  Otherwise this seems like something we ought to implement in
> > the core, it's not a silly feature by any stretch of the imagination but
> > it applies to any device with a DAI mute unless there's some device
> > specific thing I'm missing here.

> So I'd say having a simple OR logic in this case is reasonable and
> serves all the needs I can think of, no?

You're not really responding to what I'm saying here.  What I'm saying
is that if this is useful it should be implemented in the core unless
there's some reason I'm missing why this is specific to this driver.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2013-03-22 10:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 19:43 [PATCH 1/2 resend] ASoC: cs4271: switch to mute_stream Daniel Mack
2013-03-21 19:43 ` [PATCH 2/2 resend] ASoC: cs4271: preserve "Master Playback Switch" setting Daniel Mack
2013-03-22 10:18   ` Mark Brown
2013-03-22 10:23     ` Daniel Mack
2013-03-22 10:32       ` Mark Brown [this message]
2013-03-22 11:04         ` Daniel Mack
2013-03-22 11:10           ` Mark Brown
2013-03-27 23:11   ` Mark Brown
2013-03-22 10:13 ` [PATCH 1/2 resend] ASoC: cs4271: switch to mute_stream Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130322103247.GF22890@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=subaparts@yandex.ru \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.