All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: jinsong.liu@intel.com
Cc: xen-devel@lists.xensource.com
Subject: Regression - Xen ACPI CPU hotplug processor causes the Xen ACPI P and C-states to stop working.
Date: Fri, 22 Mar 2013 09:58:34 -0400	[thread overview]
Message-ID: <20130322135834.GA7007@phenom.dumpdata.com> (raw)


The reason is that the Xen CPU hotplug (xen-acpi-cpuhotplug.c)
registers itself as the "processor" type object. That means the
generic processor (processor_driver.c) stops working and it does
not call (acpi_processor_add) which populates the
         per_cpu(processors, pr->id) = pr;

structure. Previous to the population (acpi_processor_add) also calls
'acpi_processor_get_info' which does the job of finding the C-states and
figuring out PBLK address and all of that ends up in the 'pr' structure.

The 'processors->pr' is then used by Xen ACPI Processor (the one that
uploads C and P states to the hypervisor) to gather the data. Since it
is NULL, it skips the gathering of _PSD, _PSS, _PCT, etc and we never
end up uploading said data.

The end is that enabling the CONFIG_XEN_STUB means that xen-acpi-processor
is not working anymore.

This temporary patch:


diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 5a32232..67af155 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -182,7 +182,7 @@ config XEN_PRIVCMD
 
 config XEN_STUB
 	bool "Xen stub drivers"
-	depends on XEN && X86_64
+	depends on XEN && X86_64 && BROKEN
 	default n
 	help
 	  Allow kernel to install stub drivers, to reserve space for Xen drivers,

fixes the regression, but this problem needs to be fixed long-term.

                 reply	other threads:[~2013-03-22 13:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130322135834.GA7007@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=jinsong.liu@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.