From: Oleg Nesterov <oleg@redhat.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: ppcdev <linuxppc-dev@lists.ozlabs.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] powerpc/uprobes: teach uprobes to ignore gdb breakpoints
Date: Fri, 22 Mar 2013 15:46:40 +0100 [thread overview]
Message-ID: <20130322144640.GA17286@redhat.com> (raw)
In-Reply-To: <20130322044747.GB26183@in.ibm.com>
On 03/22, Ananth N Mavinakayanahalli wrote:
>
> On Thu, Mar 21, 2013 at 04:58:09PM +0100, Oleg Nesterov wrote:
> >
> > - verify_opcode()->is_swbp_insn() means:
> >
> > is this insn fine for uprobe? (we do not care about
> > gdb, we simply ignore this problem)
>
> I will write up a patch for this case.. So, IIUC we do not care to send
> gdb a SIGTRAP if we have replaced a conditional trap from gdb with an
> unconditional uprobes one, right?
Yes.
And just in case, we do not send SIGTRAP if gdb used the same/unconditional
insn. We simply can't know if someone else wants to know that the task hits
this breakpoint.
Oleg.
prev parent reply other threads:[~2013-03-22 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 10:40 [PATCH] powerpc/uprobes: teach uprobes to ignore gdb breakpoints Ananth N Mavinakayanahalli
2013-03-20 12:26 ` Oleg Nesterov
2013-03-20 12:43 ` Oleg Nesterov
2013-03-20 15:42 ` Ananth N Mavinakayanahalli
2013-03-20 16:07 ` Oleg Nesterov
2013-03-21 7:17 ` Ananth N Mavinakayanahalli
2013-03-21 16:00 ` Oleg Nesterov
2013-03-22 4:37 ` Ananth N Mavinakayanahalli
2013-03-20 15:41 ` Ananth N Mavinakayanahalli
2013-03-20 16:06 ` Oleg Nesterov
2013-03-21 7:15 ` Ananth N Mavinakayanahalli
2013-03-21 15:58 ` Oleg Nesterov
2013-03-22 4:47 ` Ananth N Mavinakayanahalli
2013-03-22 14:46 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322144640.GA17286@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.