From: Joe MacDonald <Joe.MacDonald@windriver.com>
To: Aws Ismail <aws.ismail@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH 0/1][V2] Quagga has no snmp support, unrecognized options --enable-tcp-md5
Date: Fri, 22 Mar 2013 14:49:10 -0400 [thread overview]
Message-ID: <20130322184910.GL10961@windriver.com> (raw)
In-Reply-To: <1363892721-25929-1-git-send-email-aws.ismail@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
[[meta-networking][PATCH 0/1][V2] Quagga has no snmp support, unrecognized options --enable-tcp-md5] On 13.03.21 (Thu 15:05) Aws Ismail wrote:
> *** V2 ***
> Fix typo in the SNMP CONF line
> *** V2 ***
>
> This commit introduces a set of changes to do the following:
>
> 1. Update the configure option for quagga to replace the old --enable-tcp-md5
> 2. Add snmp support based on DISTRO_FEATURES availability.
> 3. Install sample runtime configuration files for quagga and its daemons.
> 4. Make sure the post install script is executed at the right stage.
>
>
> Aws Ismail (1):
> Quagga has no snmp support, unrecognized options --enable-tcp-md5
>
> .../recipes-protocols/quagga/quagga.inc | 23 ++++++++++++++++---
> 1 files changed, 19 insertions(+), 4 deletions(-)
Hey Aws,
I hate to send this back for a v3 just for this, but since you're right
there fixing stuff, can you also clean up the inconsistent use of hard
tabs and spaces in the recipe? Probably best to do that as a separate
commit, so it's clear what you're actually changing and what's purely
cosmetic.
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2013-03-22 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 19:05 [meta-networking][PATCH 0/1][V2] Quagga has no snmp support, unrecognized options --enable-tcp-md5 Aws Ismail
2013-03-21 19:05 ` [meta-networking][PATCH 1/1] " Aws Ismail
2013-03-22 18:49 ` Joe MacDonald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322184910.GL10961@windriver.com \
--to=joe.macdonald@windriver.com \
--cc=aws.ismail@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.