From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Fri, 22 Mar 2013 22:02:15 +0100
Subject: [U-Boot] [PATCH 17/31] Enable XAUI interface for B4860QDS
In-Reply-To: <1363973369-26110-17-git-send-email-yorksun@freescale.com>
References: <1363973369-26110-1-git-send-email-yorksun@freescale.com>
	<1363973369-26110-17-git-send-email-yorksun@freescale.com>
Message-ID: <20130322210215.BE5092014CE@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear York Sun,

In message <1363973369-26110-17-git-send-email-yorksun@freescale.com> you wrote:
> From: Suresh Gupta <suresh.gupta@freescale.com>
> 
> - Added SERDES2 PRTCLs = 0x98, 0x9E
> - Default Phy Addresses for Teranetics PHY on XAUI card
> 	The PHY addresses of Teranetics PHY on XAUI riser card are assigned
> 	based on the slot it is in. Switches SW4[2:4] and SW6[2:4] on
> 	AMC2PEX-2S On B4860QDS, AMC2PEX card decide the PHY addresses on slot1
>         and slot2
> - Configure MDIO for 10Gig Mac
> 
> Signed-off-by: Suresh Gupta <suresh.gupta@freescale.com>
> ---
>  board/freescale/b4860qds/eth_b4860qds.c |   38 +++++++++++++++++++++++++++++++
>  drivers/net/fm/b4860.c                  |    4 +++-
>  include/configs/B4860QDS.h              |    6 ++++-
>  3 files changed, 46 insertions(+), 2 deletions(-)

WARNING: quoted string split across lines
#134: FILE: board/freescale/b4860qds/eth_b4860qds.c:281:
+               debug("Setting phy addresses on B4860 QDS AMC2PEX-2S"
+                               "for FM1_10GEC1: %x\n",

CHECK: Alignment should match open parenthesis
#137: FILE: board/freescale/b4860qds/eth_b4860qds.c:284:
+               fm_info_set_phy_address(FM1_10GEC1,
+                               CONFIG_SYS_FM1_10GEC1_PHY_ADDR);

WARNING: quoted string split across lines
#139: FILE: board/freescale/b4860qds/eth_b4860qds.c:286:
+               debug("Setting phy addresses on B4860 QDS AMC2PEX-2S"
+                               "for FM1_10GEC2: %x\n",

CHECK: Alignment should match open parenthesis
#142: FILE: board/freescale/b4860qds/eth_b4860qds.c:289:
+               fm_info_set_phy_address(FM1_10GEC2,
+                               CONFIG_SYS_FM1_10GEC2_PHY_ADDR);

WARNING: quoted string split across lines
#147: FILE: board/freescale/b4860qds/eth_b4860qds.c:294:
+               debug("Setting phy addresses on B4860 QDS AMC2PEX-2S"
+                               "for FM1_10GEC2: %x\n",

CHECK: Alignment should match open parenthesis
#150: FILE: board/freescale/b4860qds/eth_b4860qds.c:297:
+               fm_info_set_phy_address(FM1_10GEC2,
+                               CONFIG_SYS_FM1_10GEC2_PHY_ADDR);

CHECK: Alignment should match open parenthesis
#165: FILE: board/freescale/b4860qds/eth_b4860qds.c:330:
+                       fm_info_set_mdio(i,
+                            miiphy_get_dev_by_name(DEFAULT_FM_TGEC_MDIO_NAME));

CHECK: Alignment should match open parenthesis
#169: FILE: board/freescale/b4860qds/eth_b4860qds.c:334:
+                       printf("Fman1: 10GSEC%u set to unknown interface %i\n",
+                                       idx + 1, fm_info_get_enet_if(i));

CHECK: Logical continuations should be on the previous line
#190: FILE: drivers/net/fm/b4860.c:60:
        if ((port == FM1_10GEC1 || port == FM1_10GEC2)
+                       && ((is_serdes_configured(XAUI_FM1_MAC9))

CHECK: Logical continuations should be on the previous line
#191: FILE: drivers/net/fm/b4860.c:61:
+                       && ((is_serdes_configured(XAUI_FM1_MAC9))
+                       || (is_serdes_configured(XAUI_FM1_MAC10))))


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Conceptual integrity in turn dictates that the  design  must  proceed
from  one  mind,  or  from  a  very small number of agreeing resonant
minds.               - Frederick Brooks Jr., "The Mythical Man Month"