From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4 0/5] move s3c24xx-irq to drivers/irqchip and add dt support Date: Fri, 22 Mar 2013 21:04:54 +0000 Message-ID: <201303222104.54225.arnd@arndb.de> References: <201303221843.37668.heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201303221843.37668.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Heiko =?utf-8?q?St=C3=BCbner?= Cc: Kukjin Kim , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org T24gRnJpZGF5IDIyIE1hcmNoIDIwMTMsIEhlaWtvIFN0w7xibmVyIHdyb3RlOgo+IEFzIHN1Z2dl c3RlZCBieSBSb2IgSGVycmluZyBtb3ZlIGJhY2sgdG8gZ2V0IHRoZSBwYXJlbnQgcmVsZWF0aW9u c2hpcCBmcm9tIGR0Cj4gbGlrZSBpbiB0aGUgZmlyc3QgdmVyc2lvbnMsIGJ1dCBzZXQgdGhlIGhh bmRsZXIgZnJvbSB0aGUgaW50ZXJydXB0IHByb3BlcnR5Cj4gcmF0aGVyIHRoYW4gZnJvbSBhIHNw ZWNpZmljIGxpc3QuCj4gCj4gVGhpcyB2ZXJzaW9uIGFsc28gaW1wbGVtZW50cyAoaG9wZWZ1bGx5 IGNvcnJlY3RseSkgYW4gaWRlYSBmcm9tIGhpbSBhbmQKPiBBcm5kIEJlcmdtYW5uIHRvIGhhdmUg dGhlIHBhcmVudCByZWxhdGlvbnNoaXAgbm90IGRlc2NyaWJlZCBpbiB0aGUgY29udHJvbGxlcgo+ IG5vZGUgYnV0IHRoZSBkZXZpY2Ugbm9kZXMgaW5zdGVhZC4KPiAKPiBUaGVyZWZvcmUgdGhlIG1h aW4gY29udHJvbGxlciBjb250aW51ZXMgdG8gdXNlIGEgdHdvLWNlbGwgZGVzY3JpcHRvciB0byBz ZXQKPiBod2lycSBhbmQgdHJpZ2dlciB0eXBlIGJ1dCB0aGUgc3ViLWNvbnRyb2xsZXIgc3dpdGNo ZXMgdG8gYSB0aHJlZS1jZWxsCj4gZGVzY3JpcHRvciB3aGVyZSB0aGUgdGhpcmQgYml0IGRlc2Ny aWJlcyB0aGUgaHdpcnEgb2YgaXRzIHBhcmVudCBpcnEgaW4gdGhlCj4gbWFpbiBjb250cm9sbGVy Lgo+IAo+IEFzIGEgcmVzdWx0IGEgc2VyaWFsIG5vZGUgd291bGQgdGhlbiBsb29rIGxpa2U6Cj4g ICAgICAgICBzZXJpYWxANTAwMDAwMDAgewo+ICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0g InNhbXN1bmcsczNjMjQxMC11YXJ0IjsKPiAgICAgICAgICAgICAgICAgcmVnID0gPDB4NTAwMDAw MDAgMHg0MDAwPjsKPiAgICAgICAgICAgICAgICAgaW50ZXJydXB0LXBhcmVudCA9IDwmc3ViaW50 Yz47Cj4gICAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8MCA0IDI4PiwgPDEgNCAyOD47Cj4g ICAgICAgICB9Owo+IAo+IFRlc3RlZCBvbiBhIHMzYzI0MTYtYmFzZWQgYm9hcmQuCj4gCj4gQXMg aXQgZGVwZW5kcyBvbiBjaGFuZ2VzIGFscmVhZHkgcGVuZGluZyBmb3IgMy4xMCBpdCBzaG91bGQg cHJvYmFibHkgZ28gdGhydQo+IHRoZSBzYW1zdW5nIHRyZWUuCgpIaSBIZWlrbywKCkkgc2hvdWxk IHByb2JhYmx5IHJlYWQgdGhlIG9yaWdpbmFsIGRpc2N1c3Npb24gdGhyZWFkIGFnYWluLiBJIGFs cmVhZHkgY29tbWVudGVkCm9uIHRoZSBiaW5kaW5nIGhlcmUsIGJ1dCBJIG1heSBoYXZlIG1pc3Nl ZCBzb21ldGhpbmcgaW1wb3J0YW50IHRoYXQgbGVkIHRvCml0IGJlaW5nIHRoZSB3YXkgaXQgaXMg bm93LgoKCUFybmQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZGV2aWNldHJlZS1kaXNjdXNzIG1haWxpbmcgbGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlz dHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJl ZS1kaXNjdXNzCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 22 Mar 2013 21:04:54 +0000 Subject: [PATCH v4 0/5] move s3c24xx-irq to drivers/irqchip and add dt support In-Reply-To: <201303221843.37668.heiko@sntech.de> References: <201303221843.37668.heiko@sntech.de> Message-ID: <201303222104.54225.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 22 March 2013, Heiko St?bner wrote: > As suggested by Rob Herring move back to get the parent releationship from dt > like in the first versions, but set the handler from the interrupt property > rather than from a specific list. > > This version also implements (hopefully correctly) an idea from him and > Arnd Bergmann to have the parent relationship not described in the controller > node but the device nodes instead. > > Therefore the main controller continues to use a two-cell descriptor to set > hwirq and trigger type but the sub-controller switches to a three-cell > descriptor where the third bit describes the hwirq of its parent irq in the > main controller. > > As a result a serial node would then look like: > serial at 50000000 { > compatible = "samsung,s3c2410-uart"; > reg = <0x50000000 0x4000>; > interrupt-parent = <&subintc>; > interrupts = <0 4 28>, <1 4 28>; > }; > > Tested on a s3c2416-based board. > > As it depends on changes already pending for 3.10 it should probably go thru > the samsung tree. Hi Heiko, I should probably read the original discussion thread again. I already commented on the binding here, but I may have missed something important that led to it being the way it is now. Arnd