Re: [ANNOUNCE] 3.8.4-rt1

["Luis Claudio R. Goncalves" <lclaudio@uudg.org>]

On Fri, Mar 22, 2013 at 11:10:11PM +0100, Thomas Gleixner wrote:
| Dear RT Folks,
| 
| I'm pleased to announce the 3.8.4-rt1 release.
| 
| Again the credit for the heavy lifting goes to Sebastian Siewior, AKA
| bigeasy, who took up most of the work to get this out. He's on my
| companies engineering team and I hope you trust him as much as I do.
| 
| Known issues:
| 
|       - SLUB behaves worse than SLAB on ARM
|       - SLAB is broken on PowerPC
| 
| Still we think that it's time to get out the stuff for broader
| testing. It's -rt1 and we need your help to get this stabilized.

I had to put two ugly hacks in place in order to let kernel build progress
a bit further. Even though they are not elegant at all, they can hint a way
to fix the two issues listed below:

fs/fscache/page.c: In function ‘fscache_invalidate_writes’:
fs/fscache/page.c:799:9: error: expected expression before ‘do’

and

drivers/gpu/drm/i915/i915_gem.c: In function ‘mutex_is_locked_by’:
drivers/gpu/drm/i915/i915_gem.c:4370:14: error: ‘struct mutex’ has no member named ‘owner’


diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index de45b60..d2b04fc 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4367,7 +4367,11 @@ static bool mutex_is_locked_by(struct mutex *mutex, struct task_struct *task)
 		return false;
 
 #if defined(CONFIG_SMP) || defined(CONFIG_DEBUG_MUTEXES)
+#ifdef CONFIG_PREEMPT_RT_FULL
+	return mutex->lock.owner == task;
+#else
 	return mutex->owner == task;
+#endif
 #else
 	/* Since UP may be pre-empted, we cannot assume that we own the lock */
 	return false;
diff --git a/fs/fscache/page.c b/fs/fscache/page.c
index ff000e5..d607a58 100644
--- a/fs/fscache/page.c
+++ b/fs/fscache/page.c
@@ -788,6 +788,12 @@ superseded:
 /*
  * Clear the pages pending writing for invalidation
  */
+
+static inline void lock_cookie(spinlock_t *lock)
+{
+	spin_lock(lock);
+}
+
 void fscache_invalidate_writes(struct fscache_cookie *cookie)
 {
 	struct page *page;
@@ -796,7 +802,7 @@ void fscache_invalidate_writes(struct fscache_cookie *cookie)
 
 	_enter("");
 
-	while (spin_lock(&cookie->stores_lock),
+	while (lock_cookie(&cookie->stores_lock),
 	       n = radix_tree_gang_lookup_tag(&cookie->stores, results, 0,
 					      ARRAY_SIZE(results),
 					      FSCACHE_COOKIE_PENDING_TAG),
-- 
[ Luis Claudio R. Goncalves                    Bass - Gospel - RT ]
[ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9  2696 7203 D980 A448 C8F8 ]

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html