From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1620 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757252Ab3CYLKP (ORCPT ); Mon, 25 Mar 2013 07:10:15 -0400 Date: Mon, 25 Mar 2013 08:10:01 -0300 From: Mauro Carvalho Chehab To: Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, Volokh Konstantin , Pete Eberlein Subject: Re: [GIT PULL FOR v3.10] go7007 driver overhaul Message-ID: <20130325081001.18f72507@redhat.com> In-Reply-To: <20130325080654.20e6c746@redhat.com> References: <201303221536.35993.hverkuil@xs4all.nl> <20130324131340.720a59dd@redhat.com> <201303251002.29967.hverkuil@xs4all.nl> <20130325080654.20e6c746@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 25 Mar 2013 08:06:54 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 25 Mar 2013 10:02:29 +0100 > Hans Verkuil escreveu: > > > On Sun March 24 2013 17:13:40 Mauro Carvalho Chehab wrote: > > > Em Fri, 22 Mar 2013 15:36:35 +0100 > > > Hans Verkuil escreveu: > > > > ... > > > > saa7134-go7007: add support for this combination. > > > > > > I won't apply this one yet. A non-staging driver should not try to load a > > > staging one without a notice. That change would be ok if you were also > > > moving go7007 out of staging. > > > > Fair enough. I will prepare a patch that at least updates the saa7134-go7007.c > > source with my changes. That only leaves the patch to saa7134 itself that will > > need to be applied once this driver goes out of staging. > > Ok. > > > > > > > > s2250: add comment describing the hardware. > > > > go7007-loader: renamed from s2250-loader > > > > go7007-loader: add support for the other devices and move fw files > > > > go7007: update the README > > > > > > You need to add there: > > > - move cypress load firmware to drivers/media/common; > > > > > > And some note about saa7134 integration. > > > > Would it be OK if I add the saa7134 patch to the go7007 directory? Rather > > than keeping it around in my git tree? > > What do you mean? Adding a diff file there? If so, that sounds weird. If you're > afraid of losing it, post it at the ML as RFC instead and add a pointer to the > patchwork number for such RFC patch at README. Never mind. I saw the patch. While it looks a little ugly, I'll apply. Cheers, Mauro