From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property Date: Mon, 25 Mar 2013 12:47:58 +0000 Message-ID: <201303251247.58823.arnd@arndb.de> References: <1364211286-31611-1-git-send-email-heikki.krogerus@linux.intel.com> <201303251140.31866.arnd@arndb.de> <20130325122851.GB20052@xps8300> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.17.9]:57625 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756439Ab3CYMsH (ORCPT ); Mon, 25 Mar 2013 08:48:07 -0400 In-Reply-To: <20130325122851.GB20052@xps8300> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Heikki Krogerus Cc: Greg Kroah-Hartman , Ley Foon Tan , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org On Monday 25 March 2013, Heikki Krogerus wrote: > On Mon, Mar 25, 2013 at 11:40:31AM +0000, Arnd Bergmann wrote: > > On Monday 25 March 2013, Heikki Krogerus wrote: > > > This will add support for hardware flow control. It is > > > limited to be used only with 8250 driver. > > > > > > Signed-off-by: Heikki Krogerus > > > > Does this imply that we can use hardware flow control only when this > > flag is set in the device tree? I assumed that working flow control > > would be the default. Is it not? > > OK, the commit message is wrong. Is the patch otherwise OK? I still find the text in the binding and the name of the property confusing, because it seems to imply that you have no hardware flow control without this. I think what you mean here is really "automatic flow control" rather than "hardware flow control". Arnd