From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.10]:61033 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815Ab3CZQyI (ORCPT ); Tue, 26 Mar 2013 12:54:08 -0400 From: Arnd Bergmann To: Thomas Petazzoni Subject: Re: [RFCv1 01/11] arm: mvebu: move L2 cache initialization in init_early() Date: Tue, 26 Mar 2013 16:53:48 +0000 Cc: Bjorn Helgaas , Grant Likely , Russell King , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, Lior Amsalem , Andrew Lunn , Jason Cooper , Maen Suleiman , Thierry Reding , Gregory Clement , Ezequiel Garcia , Olof Johansson , Tawfik Bayouk , Jason Gunthorpe , Mitch Bradley , Andrew Murray References: <1364316746-8702-1-git-send-email-thomas.petazzoni@free-electrons.com> <1364316746-8702-2-git-send-email-thomas.petazzoni@free-electrons.com> In-Reply-To: <1364316746-8702-2-git-send-email-thomas.petazzoni@free-electrons.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Message-Id: <201303261653.48998.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Tuesday 26 March 2013, Thomas Petazzoni wrote: > @@ -72,6 +73,10 @@ void __init armada_370_xp_init_early(void) > ARMADA_370_XP_MBUS_WINS_SIZE, > ARMADA_370_XP_SDRAM_WINS_BASE, > ARMADA_370_XP_SDRAM_WINS_SIZE); > + > +#ifdef CONFIG_CACHE_L2X0 > + l2x0_of_init(0, ~0UL); > +#endif I guess you should remove the #ifdef as well here, it's not needed. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 26 Mar 2013 16:53:48 +0000 Subject: [RFCv1 01/11] arm: mvebu: move L2 cache initialization in init_early() In-Reply-To: <1364316746-8702-2-git-send-email-thomas.petazzoni@free-electrons.com> References: <1364316746-8702-1-git-send-email-thomas.petazzoni@free-electrons.com> <1364316746-8702-2-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <201303261653.48998.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 26 March 2013, Thomas Petazzoni wrote: > @@ -72,6 +73,10 @@ void __init armada_370_xp_init_early(void) > ARMADA_370_XP_MBUS_WINS_SIZE, > ARMADA_370_XP_SDRAM_WINS_BASE, > ARMADA_370_XP_SDRAM_WINS_SIZE); > + > +#ifdef CONFIG_CACHE_L2X0 > + l2x0_of_init(0, ~0UL); > +#endif I guess you should remove the #ifdef as well here, it's not needed. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFCv1 01/11] arm: mvebu: move L2 cache initialization in init_early() Date: Tue, 26 Mar 2013 16:53:48 +0000 Message-ID: <201303261653.48998.arnd@arndb.de> References: <1364316746-8702-1-git-send-email-thomas.petazzoni@free-electrons.com> <1364316746-8702-2-git-send-email-thomas.petazzoni@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1364316746-8702-2-git-send-email-thomas.petazzoni@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Thomas Petazzoni Cc: Lior Amsalem , Andrew Lunn , Russell King , Jason Cooper , Tawfik Bayouk , Olof Johansson , linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Thierry Reding , Grant Likely , Maen Suleiman , Ezequiel Garcia , Andrew Murray , Bjorn Helgaas , Gregory Clement , Mitch Bradley , linux-arm-kernel@lists.infradead.org, Jason Gunthorpe List-Id: devicetree@vger.kernel.org On Tuesday 26 March 2013, Thomas Petazzoni wrote: > @@ -72,6 +73,10 @@ void __init armada_370_xp_init_early(void) > ARMADA_370_XP_MBUS_WINS_SIZE, > ARMADA_370_XP_SDRAM_WINS_BASE, > ARMADA_370_XP_SDRAM_WINS_SIZE); > + > +#ifdef CONFIG_CACHE_L2X0 > + l2x0_of_init(0, ~0UL); > +#endif I guess you should remove the #ifdef as well here, it's not needed. Arnd