From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH 0/1] drm/i915: Allow specifying a minimum brightness level for sysfs control. Date: Tue, 26 Mar 2013 17:02:03 +0000 Message-ID: <20130326170203.GA23549@srcf.ucam.org> References: <1364298525-4337-1-git-send-email-dannybaumann@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1364298525-4337-1-git-send-email-dannybaumann@web.de> Sender: linux-kernel-owner@vger.kernel.org To: Danny Baumann Cc: David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Tue, Mar 26, 2013 at 12:48:44PM +0100, Danny Baumann wrote: > This patch makes the behaviour of the intel_backlight backlight device > consistent to e.g. acpi_videoX: When writing the value 0, the set brightness > makes the panel content barely readable instead of turning the backlight off. > This matches the expectations of user space (e.g. kde-workspace or the Intel > X11 driver), which expects that it can use intel_backlight as a drop-in > replacement for acpi_videoX. I'm not quite clear what you mean here. The behaviour of "0" isn't well defined for the ACPI backlight driver - it's perfectly reasonable for it to turn the backlight off entirely. Anything assuming that "0" is still visible is broken. -- Matthew Garrett | mjg59@srcf.ucam.org