Re: [PATCH v2] watchdog: Add Broadcom BCM2835 watchdog timer driver

[Guenter Roeck <linux@roeck-us.net>]

On Tue, Mar 26, 2013 at 06:47:55PM +0100, Lubomir Rintel wrote:
> On Sun, 2013-03-24 at 09:12 -0700, Guenter Roeck wrote:
> > On Sun, Mar 24, 2013 at 03:22:53PM +0100, Lubomir Rintel wrote:
> > > This adds a driver for watchdog timer hardware present on Broadcom BCM2835 SoC,
> > > used in Raspberry Pi and Roku 2 devices.
> > > 
> > > Interface to the Broadcom BCM2835 watchdog timer hardware is based on
> > > "bcm2708_wdog" driver written by Luke Diamand that was obtained from branch
> > > "rpi-3.6.y" of git://github.com/raspberrypi/linux.git
> > > 
> > I would suggest to put that into the coments at the top of the driver.
> > Also, if the original code has a copyright statement, you might want
> > to copy that.
> 
> Okay.
> 
> > > +#include <linux/miscdevice.h>
> > 
> > Just noticed - you should not need that include.
> 
> Well, I think the bottommost line of the driver uses that and it's a
> good practice to provide a device number alias. Is that one completely
> useless?
> 
>   MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
> 
Ah, I didn't realize this is still used. The documentation suggests that it can be
kept when converting drivers to the watchdog core, so I guess there must be a reason.

Thanks,
Guenter