From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Richard Weinberger <richard@nod.at>,
Philip Oakley <philipoakley@iee.org>,
git@vger.kernel.org
Subject: Re: [DONOTAPPLY PATCH 2/3] setup: warn about implicit worktree with $GIT_DIR
Date: Tue, 26 Mar 2013 13:35:23 -0700 [thread overview]
Message-ID: <20130326203523.GM1414@google.com> (raw)
In-Reply-To: <20130326202722.GA22769@sigill.intra.peff.net>
Jeff King wrote:
> On Tue, Mar 26, 2013 at 01:21:42PM -0700, Jonathan Nieder wrote:
>> If we want this warning, would something like the following do?
>>
>> warning: You have set GIT_DIR without setting GIT_WORK_TREE
>> hint: In this case, GIT_WORK_TREE defaults to '.'
>> hint: To suppress this message, set GIT_WORK_TREE='.'
>
> That can help by teaching people how GIT_DIR behaves in general.
Yes, I think it would have helped in this case. If I understand
correctly then for a while Richard was habitually setting GIT_DIR to
mean "act on this repository" and thought the worktree was
automatically being set to the containing directory.
I think patch 3 is a bad direction to go because there will always be
old scripts that follow what used to be the recommended way to use
GIT_DIR. In the long term a warning like this that doesn't break them
(or a fatal error that at least doesn't confuse them) might be a good
way to go.
Thanks for your thoughtful work, as always.
Jonathan
next prev parent reply other threads:[~2013-03-26 20:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 21:38 git ate my home directory :-( Richard Weinberger
2013-03-25 21:43 ` Jonathan Nieder
2013-03-25 22:02 ` Junio C Hamano
2013-03-25 22:08 ` Jonathan Nieder
2013-03-25 22:15 ` Junio C Hamano
2013-03-25 22:06 ` Junio C Hamano
2013-03-25 22:09 ` Richard Weinberger
2013-03-25 22:15 ` Jonathan Nieder
2013-03-25 22:20 ` Junio C Hamano
2013-03-25 22:27 ` Richard Weinberger
2013-03-25 22:13 ` Jonathan Nieder
2013-03-25 22:21 ` Brandon Casey
2013-03-26 8:02 ` Philip Oakley
2013-03-26 9:48 ` Duy Nguyen
2013-03-26 15:04 ` Jeff King
2013-03-26 16:32 ` Junio C Hamano
2013-03-27 13:05 ` Duy Nguyen
2013-03-26 21:47 ` Philip Oakley
2013-03-26 13:07 ` Richard Weinberger
2013-03-26 14:56 ` Jeff King
2013-03-26 17:06 ` Richard Weinberger
2013-03-26 17:20 ` demerphq
2013-03-26 17:48 ` Jeff King
2013-03-26 19:08 ` demerphq
2013-03-26 17:41 ` Jeff King
2013-03-26 18:20 ` Junio C Hamano
2013-03-26 20:08 ` Jeff King
2013-03-26 20:11 ` [DONOTAPPLY PATCH 1/3] environment: set GIT_WORK_TREE when we figure out work tree Jeff King
2013-03-26 20:16 ` Jonathan Nieder
2013-03-26 20:12 ` [DONOTAPPLY PATCH 2/3] setup: warn about implicit worktree with $GIT_DIR Jeff King
2013-03-26 20:21 ` Jonathan Nieder
2013-03-26 20:27 ` Jeff King
2013-03-26 20:35 ` Jonathan Nieder [this message]
2013-03-27 8:24 ` Matthieu Moy
2013-03-26 20:13 ` [DONOTAPPLY PATCH 3/3] setup: treat GIT_DIR without GIT_WORK_TREE as a bare repo Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326203523.GM1414@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.