From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Make ext4_block_in_group() much more efficient
Date: Tue, 26 Mar 2013 23:05:55 -0400 [thread overview]
Message-ID: <20130327030555.GB5861@thunk.org> (raw)
In-Reply-To: <1364207051-27037-1-git-send-email-lczerner@redhat.com>
On Mon, Mar 25, 2013 at 11:24:10AM +0100, Lukas Czerner wrote:
> + actual_group = (le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block) +
> + block) >>
> + (EXT4_BLOCK_SIZE_BITS(sb) + EXT4_CLUSTER_BITS(sb) + 3);
The problem with this change is that you are assuming that the number
of blocks per group is equal to block_size * 8. This is not always
the case; a nonstandard number of blocks per group can be set using
mke2fs's -g option.
- Ted
prev parent reply other threads:[~2013-03-27 3:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 10:24 [PATCH 1/2] ext4: Make ext4_block_in_group() much more efficient Lukas Czerner
2013-03-25 10:24 ` [PATCH 2/2] ext4: introduce ext4_get_group_number() Lukas Czerner
2013-03-27 3:12 ` Theodore Ts'o
2013-03-27 3:44 ` Theodore Ts'o
2013-03-27 3:05 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327030555.GB5861@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.