From: Dan Carpenter <dan.carpenter@oracle.com>
To: mgorman@suse.de
Cc: linux-mm@kvack.org
Subject: re: mm: page_alloc: avoid marking zones full prematurely after zone_reclaim()
Date: Wed, 27 Mar 2013 09:01:42 +0300 [thread overview]
Message-ID: <20130327060141.GA23703@longonot.mountain> (raw)
Hello Mel Gorman,
The patch 290d1a3ce0ec: "mm: page_alloc: avoid marking zones full
prematurely after zone_reclaim()" from Mar 23, 2013, leads to the
following warning:
"mm/page_alloc.c:1957 get_page_from_freelist()
warn: bitwise AND condition is false here"
mm/page_alloc.c
1948 /*
1949 * Failed to reclaim enough to meet watermark.
1950 * Only mark the zone full if checking the min
1951 * watermark or if we failed to reclaim just
1952 * 1<<order pages or else the page allocator
1953 * fastpath will prematurely mark zones full
1954 * when the watermark is between the low and
1955 * min watermarks.
1956 */
1957 if ((alloc_flags & ALLOC_WMARK_MIN) ||
^^^^^^^^^^^^^^^
This is zero.
1958 ret == ZONE_RECLAIM_SOME)
1959 goto this_zone_full;
[snip]
2333 static inline int
2334 gfp_to_alloc_flags(gfp_t gfp_mask)
2335 {
2336 int alloc_flags = ALLOC_WMARK_MIN | ALLOC_CPUSET;
^^^^^^^^^^^^^^^
2337 const gfp_t wait = gfp_mask & __GFP_WAIT;
regards,
dan carpenter
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2013-03-27 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 6:01 Dan Carpenter [this message]
2013-03-27 16:55 ` mm: page_alloc: avoid marking zones full prematurely after zone_reclaim() Michal Hocko
2013-03-27 17:13 ` Michal Hocko
2013-04-01 11:13 ` Dan Carpenter
2013-04-02 9:55 ` Michal Hocko
2013-04-02 10:37 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327060141.GA23703@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.