From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlegacy: 4965-rs: avoid null pointer dereference error
Date: Wed, 27 Mar 2013 11:07:13 +0100 [thread overview]
Message-ID: <20130327100712.GA1595@redhat.com> (raw)
In-Reply-To: <1364319323-14272-1-git-send-email-colin.king@canonical.com>
On Tue, Mar 26, 2013 at 05:35:23PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> il4965_rs_initialize_lq checks to see if sta is null, however, before that
> check il4965_rs_use_green dereferences sta when intializing use_green.
> Avoid a potential null pointer dereference error by only calling
> il4965_rs_use_green after we are sure sta is not null.
>
> Smatch analysis:
>
> drivers/net/wireless/iwlegacy/4965-rs.c:2160 il4965_rs_initialize_lq() warn:
> variable dereferenced before check 'sta' (see line 2155)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
ACK
prev parent reply other threads:[~2013-03-27 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 17:35 [PATCH] iwlegacy: 4965-rs: avoid null pointer dereference error Colin King
2013-03-27 10:07 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327100712.GA1595@redhat.com \
--to=sgruszka@redhat.com \
--cc=colin.king@canonical.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.