From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: clear crt hotplug compare voltage field before setting Date: Wed, 27 Mar 2013 17:02:43 +0200 Message-ID: <20130327150243.GC4469@intel.com> References: <20130327140316.GA4469@intel.com> <1364395631-27934-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 32098E625F for ; Wed, 27 Mar 2013 08:02:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1364395631-27934-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 27, 2013 at 03:47:11PM +0100, Daniel Vetter wrote: > Noticed while reviewing the hotplug irq setup code. Just looks better. > = > Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrj=E4l=E4 What about the activation period? Do we want to leave it alone on non g4x platforms, or should it also get cleared? > --- > drivers/gpu/drm/i915/i915_irq.c | 1 + > 1 file changed, 1 insertion(+) > = > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_= irq.c > index c697580..be2d6dd 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -2776,6 +2776,7 @@ static void i915_hpd_irq_setup(struct drm_device *d= ev) > */ > if (IS_G4X(dev)) > hotplug_en |=3D CRT_HOTPLUG_ACTIVATION_PERIOD_64; > + hotplug_en &=3D ~CRT_HOTPLUG_VOLTAGE_COMPARE_MASK; > hotplug_en |=3D CRT_HOTPLUG_VOLTAGE_COMPARE_50; > = > /* Ignore TV since it's buggy */ > -- = > 1.7.11.7 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC