From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: don't unlock in the addfb error paths Date: Thu, 28 Mar 2013 12:22:55 +0200 Message-ID: <20130328102255.GG4469@intel.com> References: <1364417135-30928-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 92F76E5C30 for ; Thu, 28 Mar 2013 03:23:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1364417135-30928-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Ray Strode , DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, Mar 27, 2013 at 09:45:35PM +0100, Daniel Vetter wrote: > We don't grab the modeset locks any more since > = > commit 468174f748603497e73dba9b5c6d1d9f71121486 > Author: Daniel Vetter > Date: Tue Dec 11 00:09:12 2012 +0100 > = > drm: push modeset_lock_all into ->fb_create driver callbacks > = > Reported-by: Ray Strode > Cc: Ray Strode > Cc: Dave Airlie > Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/drm_crtc.c | 2 -- > 1 file changed, 2 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 792c3e3..dd64a06 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -2326,7 +2326,6 @@ int drm_mode_addfb(struct drm_device *dev, > fb =3D dev->mode_config.funcs->fb_create(dev, file_priv, &r); > if (IS_ERR(fb)) { > DRM_DEBUG_KMS("could not create framebuffer\n"); > - drm_modeset_unlock_all(dev); > return PTR_ERR(fb); > } > = > @@ -2506,7 +2505,6 @@ int drm_mode_addfb2(struct drm_device *dev, > fb =3D dev->mode_config.funcs->fb_create(dev, file_priv, r); > if (IS_ERR(fb)) { > DRM_DEBUG_KMS("could not create framebuffer\n"); > - drm_modeset_unlock_all(dev); > return PTR_ERR(fb); > } > = > -- = > 1.7.10.4 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC