From: Samuel Ortiz <sameo@linux.intel.com>
To: Rymarkiewicz Waldemar <waldemar.rymarkiewicz@tieto.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
"lauro.venancio@openbossa.org" <lauro.venancio@openbossa.org>,
"aloisio.almeida@openbossa.org" <aloisio.almeida@openbossa.org>,
"yongjun_wei@trendmicro.com.cn" <yongjun_wei@trendmicro.com.cn>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-nfc@lists.01.org" <linux-nfc@lists.01.org>
Subject: Re: [linux-nfc] [PATCH] NFC: microread: use kfree_skb() instead of kfree()
Date: Thu, 28 Mar 2013 12:23:35 +0100 [thread overview]
Message-ID: <20130328112335.GG2153@zurbaran> (raw)
In-Reply-To: <514C34C1.1010004@tieto.com>
Hi Waldemar,
On Fri, Mar 22, 2013 at 11:38:57AM +0100, Rymarkiewicz Waldemar wrote:
> Hi,
>
> >>
> >>kfree_skb call is used internally by the kernel. A driver should use dev_kfree_skb instead, I guess.
> >
> >It seems that dev_kfree_skb() call when dev_alloc_skb() is used, and
> >kfree_skb() use to free skb malloced by alloc_skb().
>
> I agree. The driver should use dev_* flavoured skb function then.
I'd prefer the driver to call nfc_alloc_recv_skb() instead. This one calls
alloc_skb() but we could have it call dev_alloc_skb() I suppose. dev_alloc_skb
does atomic allocation though.
And kfree_skb() or dev_kfree_skb() is essentially the same.
I'll fix the driver so that it calls nfc_alloc_recv_skb() and kfree_skb unless
Wei beats me at it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-03-28 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 7:40 [PATCH] NFC: microread: use kfree_skb() instead of kfree() Wei Yongjun
2013-03-21 11:37 ` [linux-nfc] " Rymarkiewicz Waldemar
2013-03-21 13:57 ` Wei Yongjun
2013-03-22 10:38 ` Rymarkiewicz Waldemar
2013-03-28 11:23 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328112335.GG2153@zurbaran \
--to=sameo@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=waldemar.rymarkiewicz@tieto.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.