From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: check fb->pixel_format instead of bits_per_pixel Date: Thu, 28 Mar 2013 16:42:25 +0200 Message-ID: <20130328144225.GN4469@intel.com> References: <20130328115959.GM4469@intel.com> <1364474967-31747-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id D0E8EE5C7C for ; Thu, 28 Mar 2013 07:42:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1364474967-31747-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 28, 2013 at 01:49:26PM +0100, Daniel Vetter wrote: > We've mostly switched over to the new more flexible schema, but > there's one check left in the modeset code. Having to do a full modeset for an fb change kind of sucks, but as long as we're choosing the pipe bpp based on the primary plane format I guess we don't have much of a choice. > = > Motivated by a question from Ville whether there's really no way an > unsupported pixel_format can escape into our platform update_plane > callbacks. > = > Cc: Ville Syrj=E4l=E4 > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 84bd8d3..8cbb65c 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -7956,8 +7956,8 @@ intel_set_config_compute_mode_changes(struct drm_mo= de_set *set, > config->mode_changed =3D true; > } else if (set->fb->depth !=3D set->crtc->fb->depth) { > config->mode_changed =3D true; With the format check in place you can drop the depth check too. > - } else if (set->fb->bits_per_pixel !=3D > - set->crtc->fb->bits_per_pixel) { > + } else if (set->fb->pixel_format !=3D > + set->crtc->fb->pixel_format) { > config->mode_changed =3D true; > } else > config->fb_changed =3D true; > -- = > 1.7.10.4 -- = Ville Syrj=E4l=E4 Intel OTC