From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: check fb->pixel_format instead of
 bits_per_pixel
Date: Thu, 28 Mar 2013 17:16:51 +0200
Message-ID: <20130328151651.GP4469@intel.com>
References: <20130328144225.GN4469@intel.com>
	<1364482895-8247-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 44F0AE5C4F
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 28 Mar 2013 08:16:55 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1364482895-8247-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Mar 28, 2013 at 04:01:35PM +0100, Daniel Vetter wrote:
> We've mostly switched over to the new more flexible schema, but
> there's one check left in the modeset code.
> =

> Motivated by a question from Ville whether there's really no way an
> unsupported pixel_format can escape into our platform update_plane
> callbacks.
> =

> v2: Ville noticed that the fb->depth check is redudant when we already
> check fb->pixel_format.
> =

> Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> =

> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/=
intel_display.c
> index 84bd8d3..3f3a3dc 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7954,10 +7954,8 @@ intel_set_config_compute_mode_changes(struct drm_m=
ode_set *set,
>  			config->mode_changed =3D true;
>  		} else if (set->fb =3D=3D NULL) {
>  			config->mode_changed =3D true;
> -		} else if (set->fb->depth !=3D set->crtc->fb->depth) {
> -			config->mode_changed =3D true;
> -		} else if (set->fb->bits_per_pixel !=3D
> -			   set->crtc->fb->bits_per_pixel) {
> +		} else if (set->fb->pixel_format !=3D
> +			   set->crtc->fb->pixel_format) {
>  			config->mode_changed =3D true;
>  		} else
>  			config->fb_changed =3D true;
> -- =

> 1.7.10.4

-- =

Ville Syrj=E4l=E4
Intel OTC