All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Brian Haley <brian.haley@hp.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH v2] Fix 2.6.32 compiler errors
Date: Thu, 28 Mar 2013 18:32:42 -0400	[thread overview]
Message-ID: <20130328223242.GA22490@redhat.com> (raw)
In-Reply-To: <515347F6.2080502@hp.com>

On Wed, Mar 27, 2013 at 03:26:46PM -0400, Brian Haley wrote:
 
 >  /* would use this, but the header uses DECLARE_BITMAP() from the kernel */
 >  /* #include <sound/emu10k1.h> */
 > @@ -205,6 +207,7 @@ static const struct ioctl sound_ioctls[] = {
 >  	{ .name = "SNDRV_EMU10K1_IOCTL_SINGLE_STEP", .request =
 > _IOC(_IOC_NONE,'H',0x83,0), },
 >  	{ .name = "SNDRV_EMU10K1_IOCTL_DBG_READ", .request =
 > _IOC(_IOC_NONE,'H',0x84,0), },

Word-wrapped.


 > diff --git a/syscalls/inotify_add_watch.c b/syscalls/inotify_add_watch.c
 > index 9c69fc7..35fb593 100644
 > --- a/syscalls/inotify_add_watch.c
 > +++ b/syscalls/inotify_add_watch.c
 > @@ -34,7 +34,9 @@ struct syscall syscall_inotify_add_watch = {
 >  			IN_IGNORED,
 >  			IN_ONLYDIR,
 >  			IN_DONT_FOLLOW,
 > +#ifdef IN_EXCL_UNLINK
 >  			IN_EXCL_UNLINK,
 > +#endif
 >  			IN_MASK_ADD,
 >  			IN_ISDIR,
 >  			IN_ONESHOT,

You can't do this, because the .num will be incorrect.
Add a dummy define to compat.h for it instead.

	Dave


      reply	other threads:[~2013-03-28 22:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 19:26 [PATCH v2] Fix 2.6.32 compiler errors Brian Haley
2013-03-28 22:32 ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130328223242.GA22490@redhat.com \
    --to=davej@redhat.com \
    --cc=brian.haley@hp.com \
    --cc=trinity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.