From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Metcalf <cmetcalf@tilera.com>,
Christoph Lameter <cl@linux.com>,
Geoff Levand <geoff@infradead.org>,
Gilad Ben Yossef <gilad@benyossef.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Kevin Hilman <khilman@linaro.org>,
Li Zhong <zhong@linux.vnet.ibm.com>,
Namhyung Kim <namhyung.kim@lge.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot
Date: Thu, 28 Mar 2013 20:51:25 -0700 [thread overview]
Message-ID: <20130329035124.GM3337@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130329020822.GD3444@windriver.com>
On Thu, Mar 28, 2013 at 10:08:23PM -0400, Paul Gortmaker wrote:
> [Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot] On 28/03/2013 (Thu 19:00) Paul E. McKenney wrote:
>
> > On Fri, Mar 29, 2013 at 01:39:04AM +0100, Frederic Weisbecker wrote:
> > > 2013/3/29 Paul Gortmaker <paul.gortmaker@windriver.com>:
> > > > [Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot] On 28/03/2013 (Thu 08:40) Ingo Molnar wrote:
> > > >
> > > >>
> > > >> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > > >>
> > > >> > + cpulist_scnprintf(nohz_ext_buf, sizeof(nohz_ext_buf), nohz_extended_mask);
> > > >> > + pr_info("NO_HZ: Experimental full dynticks CPUs: %s.\n", nohz_ext_buf);
> > > >>
> > > >> I'd suggest removing the 'experimental' word. We are not sending anything
> > > >> experimental to Linus: we'll send something that is tested and that we
> > > >> expect to not break anything. (and which we'll fix if it does)
> > > >
> > > > In that case, should we vector a patch through PaulM to clobber these too?
> > > >
> > > > $ git grep xperiment |grep rcu
> > > > kernel/rcutree_plugin.h: printk(KERN_INFO "\tExperimental boot-time adjustment of leaf fanout to %d.\n", rcu_fanout_leaf);
> >
> > This one has been this way for quite some time. I must confess that I am
> > more inclined to remove this Kconfig option entirely than I am to remove
> > the "Experimental". ;-)
> >
> > > > kernel/rcutree_plugin.h: pr_info("\tExperimental no-CBs CPUs: %s.\n", nocb_buf);
> > > > kernel/rcutree_plugin.h: pr_info("\tExperimental polled no-CBs CPUs.\n");
> > >
> > > Hehe, that's indeed what I inspired from ;-)
> >
> > I guess we can rerun the earlier "how to mark Kconfig options as not
> > yet being ready for 100 million unsuspecting victims^Wusers. ;-)
>
> Perhaps consider "hiding" these kinds of choices behind CONFIG_EXPERT ?
We tried that with CONFIG_EXPERIMENTAL (or something like that), and
what happened was that all distros eventually enabled CONFIG_EXPERIMENTAL.
But if I was -really- serious about keeping the testing population down,
I would take Matthew Garret's advice and force a splat during boot-up.
So I now have a commit for 3.11 queued to remove the "Experimental"
from these strings, with your Reported-by.
Thanx, Paul
next prev parent reply other threads:[~2013-03-29 3:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 15:32 [PATCH 0/4] nohz: Full dynticks fixes/improvements Frederic Weisbecker
2013-03-27 15:32 ` [PATCH 1/4] nohz: Force boot CPU outside full dynticks range Frederic Weisbecker
2013-03-28 7:38 ` Ingo Molnar
2013-03-28 13:08 ` Frederic Weisbecker
2013-03-27 15:32 ` [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot Frederic Weisbecker
2013-03-28 7:40 ` Ingo Molnar
2013-03-28 13:12 ` Frederic Weisbecker
2013-03-29 0:25 ` Paul Gortmaker
2013-03-29 0:39 ` Frederic Weisbecker
2013-03-29 2:00 ` Paul E. McKenney
2013-03-29 2:08 ` Paul Gortmaker
2013-03-29 3:51 ` Paul E. McKenney [this message]
2013-03-29 2:02 ` Paul Gortmaker
2013-03-27 15:32 ` [PATCH 3/4] nohz: Ensure full dynticks CPUs are RCU nocbs Frederic Weisbecker
2013-03-27 15:32 ` [PATCH 4/4] nohz: New option to force all CPUs in full dynticks range Frederic Weisbecker
2013-03-28 7:45 ` Ingo Molnar
2013-03-28 13:43 ` Frederic Weisbecker
2013-03-30 9:10 ` Ingo Molnar
2013-04-02 13:09 ` Frederic Weisbecker
2013-04-08 14:57 ` Christoph Lameter
2013-04-09 13:22 ` Paul Gortmaker
2013-04-09 14:35 ` Christoph Lameter
2013-04-11 15:19 ` Frederic Weisbecker
2013-04-11 15:37 ` Paul E. McKenney
2013-04-11 15:53 ` Frederic Weisbecker
2013-04-11 16:10 ` Paul E. McKenney
2013-04-11 16:41 ` Christoph Lameter
2013-04-11 17:04 ` Frederic Weisbecker
2013-04-11 17:11 ` Paul E. McKenney
2013-04-11 17:28 ` Frederic Weisbecker
2013-04-11 19:17 ` Paul E. McKenney
2013-04-12 15:59 ` Christoph Lameter
2013-04-15 10:27 ` Ingo Molnar
2013-04-15 16:11 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329035124.GM3337@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=geoff@infradead.org \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.