From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jpirko@redhat.com>
Cc: "Eric Dumazet" <eric.dumazet@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Andy Gospodarek" <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Guy Streeter" <streeter@redhat.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>
Subject: Re: [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline)
Date: Fri, 29 Mar 2013 08:46:32 -0700 [thread overview]
Message-ID: <20130329084632.469ec44d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20130329094856.GB1677@minipsycho.orion>
On Fri, 29 Mar 2013 10:48:56 +0100
Jiri Pirko <jpirko@redhat.com> wrote:
> index 0caa38e..c16b829 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3332,8 +3332,8 @@ void netdev_rx_handler_unregister(struct net_device *dev)
> {
>
> ASSERT_RTNL();
> - RCU_INIT_POINTER(dev->rx_handler, NULL);
> - RCU_INIT_POINTER(dev->rx_handler_data, NULL);
> + rcu_assign_pointer(dev->rx_handler, NULL);
> + rcu_assign_pointer(dev->rx_handler_data, NULL);
> }
> EXPORT_SYMBOL_GPL(netdev_rx_handler_unregister);
It is worth noting that at the time rcu_assign_pointer() had a special
case tat if the value was NULL it would compile into RCU_INIT_POINTER without
the barrier.
next prev parent reply other threads:[~2013-03-29 15:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 17:16 [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline) Steven Rostedt
2013-03-28 17:29 ` Eric Dumazet
2013-03-28 17:44 ` Steven Rostedt
2013-03-29 9:48 ` Jiri Pirko
2013-03-29 13:01 ` [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister() Eric Dumazet
2013-03-29 13:17 ` Steven Rostedt
2013-03-29 13:38 ` Eric Dumazet
2013-03-29 15:11 ` Ivan Vecera
2013-03-29 15:38 ` Eric Dumazet
2013-03-29 16:12 ` Jiri Pirko
2013-03-29 16:46 ` Eric Dumazet
2013-03-29 19:20 ` Paul E. McKenney
2013-03-29 19:26 ` Eric Dumazet
2013-03-29 19:39 ` David Miller
2013-03-29 15:46 ` Stephen Hemminger [this message]
2013-03-29 18:36 ` [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline) Steven Rostedt
2013-03-29 19:55 ` Steven Rostedt
2013-03-30 9:19 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329084632.469ec44d@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=paulmck@us.ibm.com \
--cc=rostedt@goodmis.org \
--cc=streeter@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.