From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: alsa-devel@alsa-project.org, Stephen Warren <swarren@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: Implement mixer control sharing
Date: Fri, 29 Mar 2013 10:53:34 +0000 [thread overview]
Message-ID: <20130329105333.GC18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1364514790-28398-1-git-send-email-swarren@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 721 bytes --]
On Thu, Mar 28, 2013 at 05:53:10PM -0600, Stephen Warren wrote:
> Mark, the goto here might be considered icky. It avoids heavy indent
> levels. Should I separate out the control creation part of dapm_new_mixer()
> into a separate function to avoid this?
I think the fact that you're asking this question means you know the
answer :)
> Also, this commit has the potential for user-space impact, since control
> names could change for existing drivers. However, in this case I suspect
> the affected controls wouldn't have worked very well anyway, since they'd
> be affected by one of the problems I mention in the commit description
> above anyway, so I doubt this will be a practical problem.
This isn't a big deal.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-03-29 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 23:53 [PATCH] ASoC: Implement mixer control sharing Stephen Warren
2013-03-29 10:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329105333.GC18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.