From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: corruption of active mmapped files in btrfs snapshots Date: Fri, 29 Mar 2013 07:35:32 -0400 Message-ID: <20130329113532.17260.20870@localhost.localdomain> References: <20130322180705.27874.96638@localhost.localdomain> <20130322203142.27874.84834@localhost.localdomain> <20130326000840.14340.30047@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from dkim2.fusionio.com ([66.114.96.54]:37978 "EHLO dkim2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749Ab3C2Lff convert rfc822-to-8bit (ORCPT ); Fri, 29 Mar 2013 07:35:35 -0400 Received: from mx1.fusionio.com (unknown [10.101.1.160]) by dkim2.fusionio.com (Postfix) with ESMTP id 1E92A9A0691 for ; Fri, 29 Mar 2013 05:35:35 -0600 (MDT) In-Reply-To: Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Alexandre Oliva Cc: "linux-btrfs@vger.kernel.org" , "ceph-devel@vger.kernel.org" Quoting Alexandre Oliva (2013-03-29 05:56:06) > On Mar 25, 2013, Chris Mason wrote: > > > This patch changes our compression code to call clear_page_dirty_for_io > > before we compress, and then redirty the pages if the compression fails. > > > Alexandre, many thanks for tracking this down into a well defined use > > case. > > Thanks for the patch, it's run flawlessly since I started gradually > rolling it out onto my ceph OSDs on Monday! Ship it! :-) Awesome, it's in my for-linus and will go out to Linus today. -chris