From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
david@fromorbit.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] kthread: implement probe_kthread_data()
Date: Sat, 30 Mar 2013 20:12:22 +0100 [thread overview]
Message-ID: <20130330191222.GA31531@redhat.com> (raw)
In-Reply-To: <CAOS58YNMbTY2fZzUXeyLwuA+nowW2AhgLvQwKf_0jWXDen6HzQ@mail.gmail.com>
On 03/30, Tejun Heo wrote:
>
> On Sat, Mar 30, 2013 at 10:00 AM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> > But I guess I missed the fact that this helper should be safe even this
> > @task can be the a vfork'ed user-space process, yes?
> >
>
> Yeap, we really don't know what to expect.
OK,
> > Or we can add to_live_kthread_safe() which checks "parent == kthreadd_task"
> > instead.
>
> But that would be more fragile than probe_read. I mean, this thing will be
> called on BUGs and oopses.
OK, I agree.
Sorry for noise and thanks for your explanations, I really missed
the intent.
Oleg.
next prev parent reply other threads:[~2013-03-30 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 3:00 [PATCHSET] workqueue, writeback: better worker information in task dumps Tejun Heo
2013-03-30 3:00 ` [PATCH 1/3] kthread: implement probe_kthread_data() Tejun Heo
2013-03-30 14:36 ` Oleg Nesterov
2013-03-30 16:17 ` Tejun Heo
2013-03-30 17:00 ` Oleg Nesterov
[not found] ` <CAOS58YNMbTY2fZzUXeyLwuA+nowW2AhgLvQwKf_0jWXDen6HzQ@mail.gmail.com>
2013-03-30 19:12 ` Oleg Nesterov [this message]
2013-04-03 9:26 ` Jan Kara
2013-03-30 3:00 ` [PATCH 2/3] workqueue: include workqueue info when printing debug dump of a worker task Tejun Heo
2013-03-30 3:00 ` [PATCH 3/3] writeback: set worker desc to identify writeback workers in task dumps Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2013-04-03 19:24 [PATCHSET v2] workqueue, writeback: better worker information " Tejun Heo
2013-04-03 19:24 ` [PATCH 1/3] kthread: implement probe_kthread_data() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130330191222.GA31531@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.