From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: frankie lin <frankiefrankie.lin@gmail.com>
Cc: Jiri Slaby <jslaby@suse.cz>, open <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] TTY Fix NULL pointer error in tty_wakeup
Date: Sun, 31 Mar 2013 08:02:10 -0700 [thread overview]
Message-ID: <20130331150210.GC9494@kroah.com> (raw)
In-Reply-To: <CAD-pLEFtw0=j+jL2+ecqKShdz_GOSmfAzn3T0+3mr=5Ofnks7w@mail.gmail.com>
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sun, Mar 31, 2013 at 04:09:05PM +0800, frankie lin wrote:
> Hi, greg, it's excited to get your reply.
> In our case, it is gs_start_io(struct gs_port *port) in the file u_serial.c who
> call the tty_wakeup. We are trying to find the root cause. Something is wrong
> before calling tty_wakeup, nevertheless it is reasonable to check the parameter
> first before test_bit.
No, please find the root problem here in your driver.
> To some extent, this patch can improve the robustness of function tty_wakeup,
> isn't it?
Not at the expense of papering over other bugs, sorry.
greg k-h
prev parent reply other threads:[~2013-03-31 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 7:58 [PATCH 1/1] TTY Fix NULL pointer error in tty_wakeup Frankie Lin
2013-03-30 15:18 ` Greg Kroah-Hartman
[not found] ` <CAD-pLEFtw0=j+jL2+ecqKShdz_GOSmfAzn3T0+3mr=5Ofnks7w@mail.gmail.com>
2013-03-31 15:02 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130331150210.GC9494@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=frankiefrankie.lin@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.