From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Sasha Levin <sasha.levin@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Dave Jones <davej@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
linux-usb@vger.kernel.org,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Lan Tianyu <tianyu.lan@intel.com>
Subject: Re: [PATCH 1/2] USB / PM: Don't try to hide PM QoS flags from usb_port_device_release()
Date: Sun, 31 Mar 2013 20:03:47 -0700 [thread overview]
Message-ID: <20130401030347.GC20857@kroah.com> (raw)
In-Reply-To: <1651223.ep7oZJM5CX@vostro.rjw.lan>
On Mon, Apr 01, 2013 at 12:57:21AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Remove the call to dev_pm_qos_hide_flags(), added by commit 6e30d7cb
> "usb: Add driver/usb/core/(port.c,hub.h) files", from
> usb_port_device_release(), because (1) it is completely unnecessary
> (the flags have been removed already by the PM core during the
> unregistration of the device object) and (2) it triggers a NULL
> pointer dereference in sysfs_find_dirent() (dev->kobj->sd is NULL at
> this point).
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2013-04-01 3:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <512F8980.4040809@oracle.com>
[not found] ` <25276895.qZKN0MF88v@vostro.rjw.lan>
[not found] ` <51576A0C.5030907@oracle.com>
2013-03-31 1:41 ` gpf in pm_qos_remote_wakeup_show Rafael J. Wysocki
2013-03-31 22:56 ` [PATCH 0/2] USB PM and PM QoS fixes (Re: gpf in pm_qos_remote_wakeup_show) Rafael J. Wysocki
2013-03-31 22:57 ` [PATCH 1/2] USB / PM: Don't try to hide PM QoS flags from usb_port_device_release() Rafael J. Wysocki
2013-04-01 3:03 ` Greg Kroah-Hartman [this message]
2013-03-31 22:58 ` [PATCH 2/2] PM / QoS: Avoid possible deadlock related to sysfs access Rafael J. Wysocki
2013-04-01 3:29 ` [PATCH 0/2] USB PM and PM QoS fixes (Re: gpf in pm_qos_remote_wakeup_show) Linus Torvalds
2013-04-01 13:22 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401030347.GC20857@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sarah.a.sharp@linux.intel.com \
--cc=sasha.levin@oracle.com \
--cc=tianyu.lan@intel.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.