From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMg5z-0008Pj-8r for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:52:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMg5w-000605-Cx for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:52:27 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:52496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMg5w-0005zy-5h for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:52:24 -0400 Date: Mon, 1 Apr 2013 16:52:23 +0200 From: Aurelien Jarno Message-ID: <20130401145223.GF17634@hall.aurel32.net> References: <1362443590-28191-1-git-send-email-rth@twiddle.net> <1362443590-28191-7-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1362443590-28191-7-git-send-email-rth@twiddle.net> Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH v2 06/27] tcg-ppc64: Introduce and use tcg_out_shri64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: av1474@comtv.ru, qemu-devel@nongnu.org On Mon, Mar 04, 2013 at 04:32:49PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index 9199ac4..82e1da7 100644 > --- a/tcg/ppc64/tcg-target.c > +++ b/tcg/ppc64/tcg-target.c > @@ -461,6 +461,11 @@ static inline void tcg_out_shli64(TCGContext *s, TCGReg dst, TCGReg src, int c) > tcg_out_rld(s, RLDICR, dst, src, c, 63 - c); > } > > +static inline void tcg_out_shri64(TCGContext *s, TCGReg dst, TCGReg src, int c) > +{ > + tcg_out_rld(s, RLDICL, dst, src, 64 - c, c); > +} > + > static void tcg_out_movi32(TCGContext *s, TCGReg ret, int32_t arg) > { > if (arg == (int16_t) arg) > @@ -864,7 +869,7 @@ static void tcg_out_qemu_st (TCGContext *s, const TCGArg *args, int opc) > if (bswap) { > tcg_out32 (s, STWBRX | SAB (data_reg, rbase, r0)); > tcg_out32 (s, ADDI | RT (r1) | RA (r0) | 4); > - tcg_out_rld (s, RLDICL, 0, data_reg, 32, 0); > + tcg_out_shri64(s, 0, data_reg, 32); > tcg_out32 (s, STWBRX | SAB (0, rbase, r1)); > } > else tcg_out32 (s, STDX | SAB (data_reg, rbase, r0)); > @@ -1455,7 +1460,7 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, > break; > case INDEX_op_shr_i64: > if (const_args[2]) > - tcg_out_rld (s, RLDICL, args[0], args[1], 64 - args[2], args[2]); > + tcg_out_shri64(s, args[0], args[1], args[2]); > else > tcg_out32 (s, SRD | SAB (args[1], args[0], args[2])); > break; Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net