From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758440Ab3DAVOA (ORCPT ); Mon, 1 Apr 2013 17:14:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757906Ab3DAVN7 (ORCPT ); Mon, 1 Apr 2013 17:13:59 -0400 Date: Mon, 1 Apr 2013 23:11:00 +0200 From: Jiri Olsa To: Sam Ravnborg Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Corey Ashford , Frederic Weisbecker , Namhyung Kim , Borislav Petkov , Stephane Eranian Subject: Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif Message-ID: <20130401211059.GD20670@krava.redhat.com> References: <1364843930-17974-1-git-send-email-jolsa@redhat.com> <1364843930-17974-3-git-send-email-jolsa@redhat.com> <20130401194905.GA5744@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130401194905.GA5744@merkur.ravnborg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 01, 2013 at 09:49:05PM +0200, Sam Ravnborg wrote: > On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: > > Unmatched spaces/tabs Makefile indentation could make the > > Makefile fails. While the tabed line could be considered > > sometimes as follow up for rule command, the mixed space > > tab meses up with makefile if conditions. > > I have too many times been beaten that asssignments was > ignored because I used tabs to indendt the assignmnet. > So in all Makefile I edit spaces are used for indent. > Tabs are only used for commands. sounds like good idea, I'll make separate patch for that thanks, jirka