From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL_FREEZING
Date: Mon, 1 Apr 2013 19:24:31 -0700 [thread overview]
Message-ID: <20130402022431.GA6255@htj.dyndns.org> (raw)
In-Reply-To: <515A3FBD.3080509@cn.fujitsu.com>
Hello, Lai.
On Tue, Apr 02, 2013 at 10:17:33AM +0800, Lai Jiangshan wrote:
> ->flags is hot and almost read-only(except __WQ_DRAINING).
> __WQ_DRAINING bit is accessed for every queue_work(), so we add it to hot ->flags.
>
> __WQ_ORDERED is read-only.
>
> ->freezing is cold and non-read-only.
> I don't think we need to add __WQ_FREEZING to ->flags.
Hmm... I'm not following. If you have multiple hot flags which may be
used from different CPUs, yeah, you may want to put them in separate
cachelines but cold flags don't really matter either way so why put it
in a separate field? Can you please elaborate?
Thanks.
--
tejun
prev parent reply other threads:[~2013-04-02 2:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 16:29 [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL_FREEZING Lai Jiangshan
2013-03-30 16:29 ` [PATCH 2/2 tj/for-3.10] workqueue: modify wq->freezing only when freezable Lai Jiangshan
2013-04-01 18:44 ` [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL_FREEZING Tejun Heo
2013-04-02 2:17 ` Lai Jiangshan
2013-04-02 2:24 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402022431.GA6255@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.