From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 11/11] drm/i915: limit DPFLIPSTAT enables to those we use on VLV Date: Tue, 2 Apr 2013 13:37:50 +0300 Message-ID: <20130402103750.GT4469@intel.com> References: <1364489747-2050-1-git-send-email-jbarnes@virtuousgeek.org> <1364489747-2050-11-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id BFCA3E5CC3 for ; Tue, 2 Apr 2013 03:37:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1364489747-2050-11-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 28, 2013 at 09:55:47AM -0700, Jesse Barnes wrote: > Thus preventing the display from keeping the GT awake with unnecessary > signals. > = > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_pm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index 2b02702..de9f898 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -4116,11 +4116,9 @@ static void valleyview_init_clock_gating(struct dr= m_device *dev) > * when flip and other events complete. So enable > * all the GUnit->GT interrupts here > */ > - I915_WRITE(VLV_DPFLIPSTAT, PIPEB_LINE_COMPARE_INT_EN | > - PIPEB_HLINE_INT_EN | PIPEB_VBLANK_INT_EN | > + I915_WRITE(VLV_DPFLIPSTAT, > SPRITED_FLIPDONE_INT_EN | SPRITEC_FLIPDONE_INT_EN | > - PLANEB_FLIPDONE_INT_EN | PIPEA_LINE_COMPARE_INT_EN | > - PIPEA_HLINE_INT_EN | PIPEA_VBLANK_INT_EN | > + PLANEB_FLIPDONE_INT_EN | > SPRITEB_FLIPDONE_INT_EN | SPRITEA_FLIPDONE_INT_EN | > PLANEA_FLIPDONE_INT_EN); We're not doing CS page flips w/ sprites currently, so I think you could drop the sprite bits too. Actually, now that I think about it, do we need any bits enabled here? i915_gem_execbuffer_wait_for_flips() is gone, so AFAICS GT no longer needs to know when page flips complete. -- = Ville Syrj=E4l=E4 Intel OTC