From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Lin Feng <linfeng@cn.fujitsu.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
akpm@linux-foundation.org, linux-mm@kvack.org, x86@kernel.org,
linux-kernel@vger.kernel.org, yinghai@kernel.org,
wency@cn.fujitsu.com, tangchen@cn.fujitsu.com
Subject: Re: [PATCH] x86: numa: mm: kill double initialization for NODE_DATA
Date: Tue, 2 Apr 2013 18:57:09 +0800 [thread overview]
Message-ID: <20130402105709.GA10095@hacker.(null)> (raw)
In-Reply-To: <1364897675-15523-1-git-send-email-linfeng@cn.fujitsu.com>
On Tue, Apr 02, 2013 at 06:14:35PM +0800, Lin Feng wrote:
>We initialize node_id, node_start_pfn and node_spanned_pages for NODE_DATA in
>initmem_init() while the later two members are kept unused and will be
>recaculated soon in paging_init(), so remove the useless assignments.
>
>PS. For clarifying calling chains are showed as follows:
>setup_arch()
> ...
> initmem_init()
> x86_numa_init()
> numa_init()
> numa_register_memblks()
> setup_node_data()
> NODE_DATA(nid)->node_id = nid;
> NODE_DATA(nid)->node_start_pfn = start >> PAGE_SHIFT;
> NODE_DATA(nid)->node_spanned_pages = (end - start) >> PAGE_SHIFT;
> ...
> x86_init.paging.pagetable_init()
> paging_init()
> ...
> sparse_init()
> sparse_early_usemaps_alloc_node()
> sparse_early_usemaps_alloc_pgdat_section()
> ___alloc_bootmem_node_nopanic()
> __alloc_memory_core_early(pgdat->node_id,...)
> ...
> zone_sizes_init()
> free_area_init_nodes()
> free_area_init_node()
> pgdat->node_id = nid;
> pgdat->node_start_pfn = node_start_pfn;
> calculate_node_totalpages();
> pgdat->node_spanned_pages = totalpages;
>
You miss the nodes which could become online at some point, but not
online currently.
Regards,
Wanpeng Li
>
>Signed-off-by: Lin Feng <linfeng@cn.fujitsu.com>
>---
> arch/x86/mm/numa.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
>index 72fe01e..efdd08f 100644
>--- a/arch/x86/mm/numa.c
>+++ b/arch/x86/mm/numa.c
>@@ -230,8 +230,6 @@ static void __init setup_node_data(int nid, u64 start, u64 end)
> node_data[nid] = nd;
> memset(NODE_DATA(nid), 0, sizeof(pg_data_t));
> NODE_DATA(nid)->node_id = nid;
>- NODE_DATA(nid)->node_start_pfn = start >> PAGE_SHIFT;
>- NODE_DATA(nid)->node_spanned_pages = (end - start) >> PAGE_SHIFT;
>
> node_set_online(nid);
> }
>--
>1.7.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-02 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 10:14 [PATCH] x86: numa: mm: kill double initialization for NODE_DATA Lin Feng
2013-04-02 10:14 ` Lin Feng
2013-04-02 10:57 ` Wanpeng Li
2013-04-02 10:57 ` Wanpeng Li [this message]
2013-04-03 1:54 ` Lin Feng
2013-04-03 1:54 ` Lin Feng
2013-04-07 1:17 ` Wanpeng Li
2013-04-07 1:17 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130402105709.GA10095@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.